Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 05:32:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NPFS]

Browse source 
- Fix some uninitialized and over-initialized variables and some DPRINTs. CID 1102515

svn path=/trunk/; revision=62641
This commit is contained in:
Thomas Faber 2014-04-06 07:54:57 +00:00
parent df6836cce4
commit f3d151acd3
1 changed files with 17 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

36
reactos/drivers/filesystems/npfs/create.c
View file

@ -96,7 +96,7 @@ NpOpenNamedPipeRootDirectory(IN PNP_DCB Dcb,
IoStatus.Information = 0; IoStatus.Information = 0;
} }
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -122,7 +122,6 @@ NpCreateClientEnd(IN PNP_FCB Fcb,
PNP_CCB Ccb = NULL; PNP_CCB Ccb = NULL;
TRACE("Entered\n"); TRACE("Entered\n");
IoStatus.Status = STATUS_SUCCESS;
IoStatus.Information = 0; IoStatus.Information = 0;
Privileges = NULL; Privileges = NULL;
@ -172,7 +171,7 @@ NpCreateClientEnd(IN PNP_FCB Fcb,
((GrantedAccess & FILE_WRITE_DATA) && (NamedPipeConfiguration == FILE_PIPE_OUTBOUND))) ((GrantedAccess & FILE_WRITE_DATA) && (NamedPipeConfiguration == FILE_PIPE_OUTBOUND)))
{ {
IoStatus.Status = STATUS_ACCESS_DENIED; IoStatus.Status = STATUS_ACCESS_DENIED;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -191,7 +190,7 @@ NpCreateClientEnd(IN PNP_FCB Fcb,
if (NextEntry == ListHead) if (NextEntry == ListHead)
{ {
IoStatus.Status = STATUS_PIPE_NOT_AVAILABLE; IoStatus.Status = STATUS_PIPE_NOT_AVAILABLE;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -202,7 +201,7 @@ NpCreateClientEnd(IN PNP_FCB Fcb,
if (!NT_SUCCESS(IoStatus.Status)) if (!NT_SUCCESS(IoStatus.Status))
{ {
NpUninitializeSecurity(Ccb); NpUninitializeSecurity(Ccb);
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -211,7 +210,7 @@ NpCreateClientEnd(IN PNP_FCB Fcb,
IoStatus.Information = FILE_OPENED; IoStatus.Information = FILE_OPENED;
IoStatus.Status = STATUS_SUCCESS; IoStatus.Status = STATUS_SUCCESS;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -373,7 +372,6 @@ NpFsdCreate(IN PDEVICE_OBJECT DeviceObject,
ACCESS_MASK DesiredAccess; ACCESS_MASK DesiredAccess;
LIST_ENTRY DeferredList; LIST_ENTRY DeferredList;
UNICODE_STRING Prefix; UNICODE_STRING Prefix;
NTSTATUS Status;
TRACE("Entered\n"); TRACE("Entered\n");
InitializeListHead(&DeferredList); InitializeListHead(&DeferredList);
@ -384,7 +382,6 @@ NpFsdCreate(IN PDEVICE_OBJECT DeviceObject,
DesiredAccess = IoStack->Parameters.CreatePipe.SecurityContext->DesiredAccess; DesiredAccess = IoStack->Parameters.CreatePipe.SecurityContext->DesiredAccess;
IoStatus.Information = 0; IoStatus.Information = 0;
IoStatus.Status = STATUS_SUCCESS;
FsRtlEnterFileSystem(); FsRtlEnterFileSystem();
ExAcquireResourceExclusiveLite(&NpVcb->Lock, TRUE); ExAcquireResourceExclusiveLite(&NpVcb->Lock, TRUE);
@ -428,8 +425,8 @@ NpFsdCreate(IN PDEVICE_OBJECT DeviceObject,
goto Quickie; goto Quickie;
} }
Status = NpTranslateAlias(&FileName); IoStatus.Status = NpTranslateAlias(&FileName);
if (!NT_SUCCESS(Status)) goto Quickie; if (!NT_SUCCESS(IoStatus.Status)) goto Quickie;
if (RelatedFileObject) if (RelatedFileObject)
{ {
@ -543,6 +540,8 @@ NpCreateExistingNamedPipe(IN PNP_FCB Fcb,
SubjectSecurityContext = &AccessState->SubjectSecurityContext; SubjectSecurityContext = &AccessState->SubjectSecurityContext;
SeLockSubjectContext(SubjectSecurityContext); SeLockSubjectContext(SubjectSecurityContext);
IoStatus.Information = 0;
AccessGranted = SeAccessCheck(Fcb->SecurityDescriptor, AccessGranted = SeAccessCheck(Fcb->SecurityDescriptor,
SubjectSecurityContext, SubjectSecurityContext,
TRUE, TRUE,
@ -581,21 +580,21 @@ NpCreateExistingNamedPipe(IN PNP_FCB Fcb,
SeUnlockSubjectContext(SubjectSecurityContext); SeUnlockSubjectContext(SubjectSecurityContext);
if (!AccessGranted) if (!AccessGranted)
{ {
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
if (Fcb->CurrentInstances >= Fcb->MaximumInstances) if (Fcb->CurrentInstances >= Fcb->MaximumInstances)
{ {
IoStatus.Status = STATUS_INSTANCE_NOT_AVAILABLE; IoStatus.Status = STATUS_INSTANCE_NOT_AVAILABLE;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
if (Disposition == FILE_CREATE) if (Disposition == FILE_CREATE)
{ {
IoStatus.Status = STATUS_ACCESS_DENIED; IoStatus.Status = STATUS_ACCESS_DENIED;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -616,7 +615,7 @@ NpCreateExistingNamedPipe(IN PNP_FCB Fcb,
if (CheckShareAccess != ShareAccess) if (CheckShareAccess != ShareAccess)
{ {
IoStatus.Status = STATUS_ACCESS_DENIED; IoStatus.Status = STATUS_ACCESS_DENIED;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -638,7 +637,7 @@ NpCreateExistingNamedPipe(IN PNP_FCB Fcb,
{ {
--Ccb->Fcb->CurrentInstances; --Ccb->Fcb->CurrentInstances;
NpDeleteCcb(Ccb, List); NpDeleteCcb(Ccb, List);
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -647,8 +646,8 @@ NpCreateExistingNamedPipe(IN PNP_FCB Fcb,
NpCheckForNotify(Fcb->ParentDcb, 0, List); NpCheckForNotify(Fcb->ParentDcb, 0, List);
IoStatus.Status = STATUS_SUCCESS; IoStatus.Status = STATUS_SUCCESS;
IoStatus.Information = 1; IoStatus.Information = FILE_OPENED;
TRACE("Leaving, IoStatus = %lx\n", IoStatus); TRACE("Leaving, IoStatus.Status = %lx\n", IoStatus.Status);
return IoStatus; return IoStatus;
} }
@ -664,7 +663,7 @@ NpCreateNewNamedPipe(IN PNP_DCB Dcb,
IN PNAMED_PIPE_CREATE_PARAMETERS Parameters, IN PNAMED_PIPE_CREATE_PARAMETERS Parameters,
IN PEPROCESS Process, IN PEPROCESS Process,
IN PLIST_ENTRY List, IN PLIST_ENTRY List,
IN PIO_STATUS_BLOCK IoStatus) OUT PIO_STATUS_BLOCK IoStatus)
{ {
NTSTATUS Status; NTSTATUS Status;
USHORT NamedPipeConfiguration; USHORT NamedPipeConfiguration;
@ -817,7 +816,6 @@ NpFsdCreateNamedPipe(IN PDEVICE_OBJECT DeviceObject,
FileName = FileObject->FileName; FileName = FileObject->FileName;
IoStatus.Status = STATUS_SUCCESS;
IoStatus.Information = 0; IoStatus.Information = 0;
FsRtlEnterFileSystem(); FsRtlEnterFileSystem();