From f38aaf659bba08bd496267a9da95fc37323b6797 Mon Sep 17 00:00:00 2001 From: Christoph von Wittich Date: Wed, 4 Feb 2009 19:16:51 +0000 Subject: [PATCH] add a buffer length check (fixes one service test) svn path=/trunk/; revision=39395 --- reactos/base/system/services/rpcserver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/reactos/base/system/services/rpcserver.c b/reactos/base/system/services/rpcserver.c index a245365201d..cdde7ba49ee 100644 --- a/reactos/base/system/services/rpcserver.c +++ b/reactos/base/system/services/rpcserver.c @@ -4251,7 +4251,14 @@ DWORD RQueryServiceConfig2A( L"Description", &lpDescriptionW); if (dwError != ERROR_SUCCESS) + { + if (cbBufSize < sizeof(SERVICE_DESCRIPTIONA)) + { + *pcbBytesNeeded = sizeof(SERVICE_DESCRIPTIONA); + dwError = ERROR_INSUFFICIENT_BUFFER; + } goto done; + } dwRequiredSize = sizeof(SERVICE_DESCRIPTIONA) + ((wcslen(lpDescriptionW) + 1));