[DXDIAGN]

* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716

svn path=/trunk/; revision=61722

reactos/dll/directx/wine/dxdiagn/CMakeLists.txt

@@ -7,6 +7,7 @@ list(APPEND SOURCE
     container.c
     dxdiag_main.c
     provider.c
+    guid.c
     ${CMAKE_CURRENT_BINARY_DIR}/dxdiagn.def)
 
 add_idl_headers(dxdiagn_idlheader fil_data.idl)

reactos/dll/directx/wine/dxdiagn/container.c

@@ -19,14 +19,7 @@
  *
  */
 
-#include <config.h>
-
-#define COBJMACROS
 #include "dxdiag_private.h"
-#include <wine/debug.h>
-#include <wine/unicode.h>
-
-WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);
 
 static inline IDxDiagContainerImpl *impl_from_IDxDiagContainer(IDxDiagContainer *iface)
 {

reactos/dll/directx/wine/dxdiagn/dxdiag_main.c

@@ -19,22 +19,9 @@
  *
  */
 
-#define COBJMACROS
-
-#include <config.h>
-#include <stdarg.h>
-
-#include <windef.h>
-#include <winbase.h>
-#include <objbase.h>
-#include <oleauto.h>
-#include <oleidl.h>
-#include <rpcproxy.h>
-#include <initguid.h>
 #include "dxdiag_private.h"
-#include <wine/debug.h>
 
-WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);
+#include <rpcproxy.h>
 
 HINSTANCE dxdiagn_instance = 0;
 

reactos/dll/directx/wine/dxdiagn/dxdiag_private.h

@@ -21,21 +21,31 @@
 #ifndef __WINE_DXDIAG_PRIVATE_H
 #define __WINE_DXDIAG_PRIVATE_H
 
+#include <wine/config.h>
+
+#include <stdarg.h>
+
 #define WIN32_NO_STATUS
 #define _INC_WINDOWS
 #define COM_NO_WINDOWS_H
 
-#include <stdarg.h>
+#define COBJMACROS
+#define NONAMELESSUNION
+#define NONAMELESSSTRUCT
 
 #include <windef.h>
 #include <winbase.h>
 #include <wingdi.h>
 
-#include <wine/list.h>
+#include <wine/debug.h>
 #include <wine/dxdiag.h>
+#include <wine/list.h>
+#include <wine/unicode.h>
 
 #include "resource.h"
 
+WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);
+
 /* DXDiag Interfaces: */
 typedef struct IDxDiagProviderImpl  IDxDiagProviderImpl;
 typedef struct IDxDiagContainerImpl IDxDiagContainerImpl;

reactos/dll/directx/wine/dxdiagn/dxdiagn.rc

@@ -16,6 +16,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
+#include <windef.h>
+
 #include "resource.h"
 
 LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT

reactos/dll/directx/wine/dxdiagn/guid.c

@@ -0,0 +1,18 @@
+/* DO NOT USE THE PRECOMPILED HEADER FOR THIS FILE! */
+
+#include <stdarg.h>
+
+#define WIN32_NO_STATUS
+#define _INC_WINDOWS
+#define COM_NO_WINDOWS_H
+
+#include <windef.h>
+#include <winbase.h>
+#include <wingdi.h>
+#include <objbase.h>
+#include <initguid.h>
+#include <fil_data.h>
+#include <wbemcli.h>
+#include <wine/dxdiag.h>
+
+/* NO CODE HERE, THIS IS JUST REQUIRED FOR THE GUID DEFINITIONS */

reactos/dll/directx/wine/dxdiagn/provider.c

@@ -20,30 +20,15 @@
  *
  */
 
-#include <config.h>
-
-#define COBJMACROS
-#define NONAMELESSUNION
-#define NONAMELESSSTRUCT
 #include "dxdiag_private.h"
-#include <wine/unicode.h>
+
 #include <winver.h>
-#include <wingdi.h>
-#include <objidl.h>
 #include <uuids.h>
-#include <vfw.h>
-#include <mmddk.h>
 #include <d3d9.h>
-#include <strmif.h>
-#include <initguid.h>
 #include <fil_data.h>
 #include <psapi.h>
 #include <wbemcli.h>
 
-#include <wine/debug.h>
-
-WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);
-
 static const WCHAR szEmpty[] = {0};
 
 static HRESULT build_information_tree(IDxDiagContainerImpl_Container **pinfo_root);

reactos/dll/directx/wine/dxdiagn/resource.h

@@ -18,7 +18,7 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
-#include <windef.h>
+#pragma once
 
 #define IDS_REGIONAL_SETTING 1
 #define IDS_PAGE_FILE_FORMAT 2