Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-06-22 18:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

remove the title name hack some did

Browse source 
comment why popup menu does not working in cmd, it seam we never getting the process name, why ??

svn path=/trunk/; revision=28018
This commit is contained in:
Magnus Olsen 2007-07-29 18:39:32 +00:00
parent 98ddfb0831
commit f1fce2a5f3
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
reactos/subsystems/win32/csrss/win32csr/guiconsole.c
View file

@ -282,9 +282,12 @@ GuiConsoleOpenUserSettings(PGUI_CONSOLE_DATA GuiData, DWORD ProcessId, PHKEY hSu
return FALSE; return FALSE;
} }
/* FIXME we do not getting the process name so no menu will be loading, why ?*/
fLength = GetProcessImageFileNameW(hProcess, szProcessName, sizeof(GuiData->szProcessName) / sizeof(WCHAR)); fLength = GetProcessImageFileNameW(hProcess, szProcessName, sizeof(GuiData->szProcessName) / sizeof(WCHAR));
CloseHandle(hProcess); CloseHandle(hProcess);
//DPRINT1("szProcessName3 : %S\n",szProcessName);
if (!fLength) if (!fLength)
{ {
DPRINT("GetProcessImageFileNameW failed(0x%x)ProcessId %d\n", GetLastError(),hProcess); DPRINT("GetProcessImageFileNameW failed(0x%x)ProcessId %d\n", GetLastError(),hProcess);
@ -1917,8 +1920,7 @@ GuiChangeTitle(PCSRSS_CONSOLE Console)
Title = L""; Title = L"";
} }
/* FIXME: deadlock */ SendMessageW(Console->hWindow, WM_SETTEXT, 0, (LPARAM) Title);
//SendMessageW(Console->hWindow, WM_SETTEXT, 0, (LPARAM) Title);
if (NULL != Buffer) if (NULL != Buffer)
{ {
@ -2008,26 +2010,26 @@ GuiInitConsole(PCSRSS_CONSOLE Console)
GuiData = HeapAlloc(Win32CsrApiHeap, HEAP_ZERO_MEMORY, GuiData = HeapAlloc(Win32CsrApiHeap, HEAP_ZERO_MEMORY,
sizeof(GUI_CONSOLE_DATA)); sizeof(GUI_CONSOLE_DATA));
if (!GuiData) if (!GuiData)
{ {
DPRINT1("Win32Csr: Failed to create GUI_CONSOLE_DATA\n"); DPRINT1("Win32Csr: Failed to create GUI_CONSOLE_DATA\n");
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
Console->PrivateData = (PVOID) GuiData; Console->PrivateData = (PVOID) GuiData;
/* /*
* we need to wait untill the GUI has been fully initialized * we need to wait untill the GUI has been fully initialized
* to retrieve custom settings i.e. WindowSize etc.. * to retrieve custom settings i.e. WindowSize etc..
* Ideally we could use SendNotifyMessage for this but its not * Ideally we could use SendNotifyMessage for this but its not
* yet implemented. * yet implemented.
* *
*/ */
GuiData->hGuiInitEvent = CreateEventW(NULL, FALSE, FALSE, NULL); GuiData->hGuiInitEvent = CreateEventW(NULL, FALSE, FALSE, NULL);
/* create console */ /* create console */
PostMessageW(NotifyWnd, PM_CREATE_CONSOLE, 0, (LPARAM) Console); PostMessageW(NotifyWnd, PM_CREATE_CONSOLE, 0, (LPARAM) Console);
/* wait untill initialization has finished */ /* wait untill initialization has finished */
WaitForSingleObject(GuiData->hGuiInitEvent, INFINITE); WaitForSingleObject(GuiData->hGuiInitEvent, INFINITE);
DPRINT1("received event Console %p GuiData %p X %d Y %d\n", Console, Console->PrivateData, Console->Size.X, Console->Size.Y); DPRINT1("received event Console %p GuiData %p X %d Y %d\n", Console, Console->PrivateData, Console->Size.X, Console->Size.Y);
CloseHandle(GuiData->hGuiInitEvent); CloseHandle(GuiData->hGuiInitEvent);
GuiData->hGuiInitEvent = NULL; GuiData->hGuiInitEvent = NULL;