Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-07-31 14:21:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

[FILESYSTEMS] Fix pool memory disclosure in NtQueryAttributesFile handlers (#2926)

Browse source 
Fix pool memory disclosure caused by alignment bytes at the end of the _FILE_BASIC_INFORMATION structure
This commit is contained in:
Nguyen Trung Khanh 2020-09-11 19:47:43 +07:00 • committed by GitHub
parent 35dbdaaa0e
commit ede7a20a17
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/filesystems/cdfs/fileinfo.c
View file

@ -899,6 +899,8 @@ Return Value:
// We only support creation, last modify and last write times on Cdfs. // We only support creation, last modify and last write times on Cdfs.
// //
RtlZeroMemory(Buffer, sizeof(FILE_BASIC_INFORMATION));
Buffer->LastWriteTime.QuadPart = Buffer->LastWriteTime.QuadPart =
Buffer->CreationTime.QuadPart = Buffer->CreationTime.QuadPart =
Buffer->ChangeTime.QuadPart = Fcb->CreationTime; Buffer->ChangeTime.QuadPart = Fcb->CreationTime;

2
drivers/filesystems/fastfat/finfo.c
View file

@ -293,6 +293,8 @@ VfatGetBasicInformation(
if (*BufferLength < sizeof(FILE_BASIC_INFORMATION)) if (*BufferLength < sizeof(FILE_BASIC_INFORMATION))
return STATUS_BUFFER_OVERFLOW; return STATUS_BUFFER_OVERFLOW;
RtlZeroMemory(BasicInfo, sizeof(FILE_BASIC_INFORMATION));
if (vfatVolumeIsFatX(DeviceExt)) if (vfatVolumeIsFatX(DeviceExt))
{ {
FsdDosDateTimeToSystemTime(DeviceExt, FsdDosDateTimeToSystemTime(DeviceExt,

2
drivers/filesystems/ntfs/finfo.c
View file

@ -107,6 +107,8 @@ NtfsGetBasicInformation(PFILE_OBJECT FileObject,
if (*BufferLength < sizeof(FILE_BASIC_INFORMATION)) if (*BufferLength < sizeof(FILE_BASIC_INFORMATION))
return STATUS_BUFFER_TOO_SMALL; return STATUS_BUFFER_TOO_SMALL;
RtlZeroMemory(BasicInfo, sizeof(FILE_BASIC_INFORMATION));
BasicInfo->CreationTime.QuadPart = FileName->CreationTime; BasicInfo->CreationTime.QuadPart = FileName->CreationTime;
BasicInfo->LastAccessTime.QuadPart = FileName->LastAccessTime; BasicInfo->LastAccessTime.QuadPart = FileName->LastAccessTime;
BasicInfo->LastWriteTime.QuadPart = FileName->LastWriteTime; BasicInfo->LastWriteTime.QuadPart = FileName->LastWriteTime;

4
drivers/filesystems/reiserfs/src/fileinfo.c
View file

@ -3,7 +3,7 @@
* PROJECT: ReiserFs file system driver for Windows NT/2000/XP/Vista. * PROJECT: ReiserFs file system driver for Windows NT/2000/XP/Vista.
* FILE: fileinfo.c * FILE: fileinfo.c
* PURPOSE: * PURPOSE:
* PROGRAMMER: Mark Piper, Matt Wu, Bo Brantén. * PROGRAMMER: Mark Piper, Matt Wu, Bo Brantén.
* HOMEPAGE: * HOMEPAGE:
* UPDATE HISTORY: * UPDATE HISTORY:
*/ */
@ -141,6 +141,8 @@ RfsdQueryInformation (IN PRFSD_IRP_CONTEXT IrpContext)
FileBasicInformation = (PFILE_BASIC_INFORMATION) Buffer; FileBasicInformation = (PFILE_BASIC_INFORMATION) Buffer;
RtlZeroMemory(FileBasicInformation, sizeof(FILE_BASIC_INFORMATION));
FileBasicInformation->CreationTime = RfsdSysTime(Fcb->Inode->i_ctime); FileBasicInformation->CreationTime = RfsdSysTime(Fcb->Inode->i_ctime);
FileBasicInformation->LastAccessTime = RfsdSysTime(Fcb->Inode->i_atime); FileBasicInformation->LastAccessTime = RfsdSysTime(Fcb->Inode->i_atime);