Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-27 09:34:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:KD64] Only use the UNIMPLEMENTED macro in the debugger's KdpSys* helpers.

Browse source 
This basically avoids re-entering the debugger (via the embedded breakpoint)
while we are already running within its context.

In addition, this allows the tests for Kd/NtSystemDebugControl
(see PRs #7424 and #7426) to run without having ReactOS to crash.
This commit is contained in:
Hermès Bélusca-Maïto 2024-11-21 22:34:15 +01:00
parent 2d3f3a1613
commit edb6d19aa8
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
2 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ntoskrnl/kd64/amd64/kdx64.c
View file

@ -139,7 +139,7 @@ KdpSysReadBusData(IN ULONG BusDataType,
IN ULONG Length, IN ULONG Length,
OUT PULONG ActualLength) OUT PULONG ActualLength)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -153,7 +153,7 @@ KdpSysWriteBusData(IN ULONG BusDataType,
IN ULONG Length, IN ULONG Length,
OUT PULONG ActualLength) OUT PULONG ActualLength)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -284,7 +284,7 @@ KdpSysReadIoSpace(IN ULONG InterfaceType,
default: default:
/* Invalid data size */ /* Invalid data size */
*ActualDataSize = 0; *ActualDataSize = 0;
return STATUS_INVALID_PARAMETER; return STATUS_INVALID_PARAMETER;
} }
@ -340,7 +340,7 @@ KdpSysWriteIoSpace(IN ULONG InterfaceType,
default: default:
/* Invalid data size */ /* Invalid data size */
*ActualDataSize = 0; *ActualDataSize = 0;
return STATUS_INVALID_PARAMETER; return STATUS_INVALID_PARAMETER;
} }
@ -355,7 +355,7 @@ NTSTATUS
NTAPI NTAPI
KdpSysCheckLowMemory(IN ULONG Flags) KdpSysCheckLowMemory(IN ULONG Flags)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -363,7 +363,7 @@ NTSTATUS
NTAPI NTAPI
KdpAllowDisable(VOID) KdpAllowDisable(VOID)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_ACCESS_DENIED; return STATUS_ACCESS_DENIED;
} }

24
ntoskrnl/kd64/arm/kdarm.c
View file

@ -22,7 +22,7 @@ NTAPI
KdpGetStateChange(IN PDBGKD_MANIPULATE_STATE64 State, KdpGetStateChange(IN PDBGKD_MANIPULATE_STATE64 State,
IN PCONTEXT Context) IN PCONTEXT Context)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
} }
VOID VOID
@ -30,7 +30,7 @@ NTAPI
KdpSetContextState(IN PDBGKD_ANY_WAIT_STATE_CHANGE WaitStateChange, KdpSetContextState(IN PDBGKD_ANY_WAIT_STATE_CHANGE WaitStateChange,
IN PCONTEXT Context) IN PCONTEXT Context)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
} }
NTSTATUS NTSTATUS
@ -38,7 +38,7 @@ NTAPI
KdpSysReadMsr(IN ULONG Msr, KdpSysReadMsr(IN ULONG Msr,
OUT PLARGE_INTEGER MsrValue) OUT PLARGE_INTEGER MsrValue)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -47,7 +47,7 @@ NTAPI
KdpSysWriteMsr(IN ULONG Msr, KdpSysWriteMsr(IN ULONG Msr,
IN PLARGE_INTEGER MsrValue) IN PLARGE_INTEGER MsrValue)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -61,7 +61,7 @@ KdpSysReadBusData(IN ULONG BusDataType,
IN ULONG Length, IN ULONG Length,
OUT PULONG ActualLength) OUT PULONG ActualLength)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -75,7 +75,7 @@ KdpSysWriteBusData(IN ULONG BusDataType,
IN ULONG Length, IN ULONG Length,
OUT PULONG ActualLength) OUT PULONG ActualLength)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -87,7 +87,7 @@ KdpSysReadControlSpace(IN ULONG Processor,
IN ULONG Length, IN ULONG Length,
OUT PULONG ActualLength) OUT PULONG ActualLength)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -99,7 +99,7 @@ KdpSysWriteControlSpace(IN ULONG Processor,
IN ULONG Length, IN ULONG Length,
OUT PULONG ActualLength) OUT PULONG ActualLength)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -113,7 +113,7 @@ KdpSysReadIoSpace(IN ULONG InterfaceType,
IN ULONG DataSize, IN ULONG DataSize,
OUT PULONG ActualDataSize) OUT PULONG ActualDataSize)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -127,7 +127,7 @@ KdpSysWriteIoSpace(IN ULONG InterfaceType,
IN ULONG DataSize, IN ULONG DataSize,
OUT PULONG ActualDataSize) OUT PULONG ActualDataSize)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -135,7 +135,7 @@ NTSTATUS
NTAPI NTAPI
KdpSysCheckLowMemory(IN ULONG Flags) KdpSysCheckLowMemory(IN ULONG Flags)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_UNSUCCESSFUL; return STATUS_UNSUCCESSFUL;
} }
@ -143,6 +143,6 @@ NTSTATUS
NTAPI NTAPI
KdpAllowDisable(VOID) KdpAllowDisable(VOID)
{ {
UNIMPLEMENTED_DBGBREAK(); UNIMPLEMENTED;
return STATUS_ACCESS_DENIED; return STATUS_ACCESS_DENIED;
} }