Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 22:02:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SHELL32][SHELL32_APITEST] Fix ShellExecuteEx IDLIST folder (#7464)

Browse source 
This is mainly to fix the shell32 apitest, a better way to handle SEE_MASK_IDLIST should be investigated in the future.
This commit is contained in:
Whindmar Saksit 2024-10-24 16:44:53 +02:00 • committed by GitHub
parent 90aee8453f
commit ea87f9102b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 90 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

42
modules/rostests/apitests/shell32/ShellExecuteEx.cpp
View file

@ -14,6 +14,7 @@
#include <stdio.h>
#include <strsafe.h>
#include <versionhelpers.h>
#include <shellutils.h>
#include "shell32_apitest_sub.h"
static WCHAR s_win_dir[MAX_PATH];
@ -313,8 +314,7 @@ static BOOL TEST_Start(void)
static void TEST_End(void)
{
Sleep(500);
GetWindowList(&s_List2);
GetWindowListForClose(&s_List2);
CloseNewWindows(&s_List1, &s_List2);
FreeWindowList(&s_List1);
FreeWindowList(&s_List2);
@ -368,26 +368,40 @@ static void test_properties()
static void test_sei_lpIDList()
{
if (IsWindowsVistaOrGreater())
// Note: SEE_MASK_FLAG_NO_UI prevents the test from blocking with a MessageBox
WCHAR path[MAX_PATH];
/* This tests ShellExecuteEx with lpIDList for explorer C:\ */
GetSystemDirectoryW(path, _countof(path));
PathStripToRootW(path);
LPITEMIDLIST pidl = ILCreateFromPathW(path);
if (!pidl)
{
skip("Vista+\n");
skip("Unable to initialize test\n");
return;
}
/* This tests ShellExecuteEx with lpIDList for explorer C:\ */
/* ITEMIDLIST for CLSID of 'My Computer' followed by PIDL for 'C:\' */
BYTE lpitemidlist[30] = { 0x14, 0, 0x1f, 0, 0xe0, 0x4f, 0xd0, 0x20, 0xea,
0x3a, 0x69, 0x10, 0xa2, 0xd8, 0x08, 0, 0x2b, 0x30, 0x30, 0x9d, // My Computer
0x8, 0, 0x23, 0x43, 0x3a, 0x5c, 0x5c, 0, 0, 0,}; // C:\\ + NUL-NUL ending
SHELLEXECUTEINFOW ShellExecInfo = { sizeof(ShellExecInfo) };
ShellExecInfo.fMask = SEE_MASK_IDLIST;
ShellExecInfo.hwnd = NULL;
ShellExecInfo.nShow = SW_SHOWNORMAL;
ShellExecInfo.lpIDList = lpitemidlist;
ShellExecInfo.fMask = SEE_MASK_IDLIST | SEE_MASK_FLAG_NO_UI | SEE_MASK_FLAG_DDEWAIT;
ShellExecInfo.lpIDList = pidl;
BOOL ret = ShellExecuteExW(&ShellExecInfo);
ok_int(ret, TRUE);
ILFree(pidl);
/* This tests ShellExecuteEx with lpIDList going through IContextMenu */
CCoInit ComInit;
pidl = SHCloneSpecialIDList(NULL, CSIDL_PROFILE, TRUE);
if (!pidl)
{
skip("Unable to initialize test\n");
return;
}
ShellExecInfo.fMask = SEE_MASK_INVOKEIDLIST | SEE_MASK_FLAG_NO_UI | SEE_MASK_FLAG_DDEWAIT;
ShellExecInfo.lpIDList = pidl;
ret = ShellExecuteExW(&ShellExecInfo);
ok_int(ret, TRUE);
ILFree(pidl);
}
static BOOL