From ea7c14919ea83e2c4b44472b729c42a7bdee6d67 Mon Sep 17 00:00:00 2001 From: Julio Carchi Date: Fri, 4 Mar 2022 13:40:57 -0500 Subject: [PATCH] [NTUSER] Fix Toolbar re-painting when Rebar parent has been altered (#4380) CORE-12342 If a Rebar window is altered by calling either ShowWindow() or UpdateWindow() then we were only updating the parent and omitting their children windows. This is closer to the behavior of the very very old SVN r27394 == git f1a7f30 . And therefore intentionally excludes parts of SVN r27403 == git e2651a0 . The bots have no complaints about it: KVM https://reactos.org/testman/compare.php?ids=81266,81290 VBox https://reactos.org/testman/compare.php?ids=81267,81291 --- win32ss/user/ntuser/winpos.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/win32ss/user/ntuser/winpos.c b/win32ss/user/ntuser/winpos.c index 4586d2357dc..eba590fad13 100644 --- a/win32ss/user/ntuser/winpos.c +++ b/win32ss/user/ntuser/winpos.c @@ -2103,10 +2103,7 @@ co_WinPosSetWindowPos( IntInvalidateWindows( Parent, DirtyRgn, RDW_ERASE | RDW_INVALIDATE); co_IntPaintWindows(Parent, RDW_NOCHILDREN, FALSE); } - else - { - IntInvalidateWindows( Window, DirtyRgn, RDW_ERASE | RDW_FRAME | RDW_INVALIDATE | RDW_ALLCHILDREN); - } + IntInvalidateWindows(Window, DirtyRgn, RDW_ERASE | RDW_FRAME | RDW_INVALIDATE | RDW_ALLCHILDREN); } else if ( RgnType != ERROR && RgnType == NULLREGION ) // Must be the same. See CORE-7166 & CORE-15934, NC HACK fix. {