Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-23 11:04:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WINESYNC] msi: Don't fail the BindImage action if the BindImage table is absent.

Browse source 
This fixes a regression introduced with
15f852015a0332313821804cc1fbad79216408c6 and observable with several
installers, including dotnet472.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46885
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a3dfd2f251f336f1cc570863edb60251227cdf5d by Zebediah Figura <z.figura12@gmail.com>
This commit is contained in:
winesync 2022-03-13 01:17:51 +01:00 committed by Mark Jansen
parent e342f3379d
commit e89ff1f99b
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dll/win32/msi/action.c
View file

@ -7827,10 +7827,10 @@ static UINT ACTION_BindImage( MSIPACKAGE *package )
r = MSI_DatabaseOpenViewW( package->db, query, &view ); r = MSI_DatabaseOpenViewW( package->db, query, &view );
if (r == ERROR_SUCCESS) if (r == ERROR_SUCCESS)
{ {
r = MSI_IterateRecords( view, NULL, ITERATE_BindImage, package ); MSI_IterateRecords( view, NULL, ITERATE_BindImage, package );
msiobj_release( &view->hdr ); msiobj_release( &view->hdr );
} }
return r; return ERROR_SUCCESS;
} }
static UINT msi_unimplemented_action_stub( MSIPACKAGE *package, LPCSTR action, LPCWSTR table ) static UINT msi_unimplemented_action_stub( MSIPACKAGE *package, LPCSTR action, LPCWSTR table )

1
modules/rostests/winetests/msi/install.c
View file

@ -135,6 +135,7 @@ static const CHAR install_exec_seq_dat[] = "Action\tCondition\tSequence\n"
"ResolveSource\t\t950\n" "ResolveSource\t\t950\n"
"MoveFiles\t\t1700\n" "MoveFiles\t\t1700\n"
"InstallFiles\t\t4000\n" "InstallFiles\t\t4000\n"
"BindImage\t\t4100\n"
"DuplicateFiles\t\t4500\n" "DuplicateFiles\t\t4500\n"
"WriteEnvironmentStrings\t\t4550\n" "WriteEnvironmentStrings\t\t4550\n"
"CreateShortcuts\t\t4600\n" "CreateShortcuts\t\t4600\n"