Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 18:15:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

[USBPORT] Release StateChangeSpinLock before acquiring MiniportSpinLock.

Browse source 
Found by Driver Verifier.
This commit is contained in:
Thomas Faber 2019-03-05 22:27:15 +01:00
parent 267f5633ee
commit e47240fb37
No known key found for this signature in database
GPG key ID: 076E7C3D44720826
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/usb/usbport/endpoint.c
View file

@ -1252,6 +1252,7 @@ USBPORT_ReopenPipe(IN PDEVICE_OBJECT FdoDevice,
if (Endpoint->StateLast == USBPORT_ENDPOINT_ACTIVE) if (Endpoint->StateLast == USBPORT_ENDPOINT_ACTIVE)
{ {
KeReleaseSpinLockFromDpcLevel(&Endpoint->StateChangeSpinLock);
KeAcquireSpinLockAtDpcLevel(&FdoExtension->MiniportSpinLock); KeAcquireSpinLockAtDpcLevel(&FdoExtension->MiniportSpinLock);
Packet->SetEndpointState(FdoExtension->MiniPortExt, Packet->SetEndpointState(FdoExtension->MiniPortExt,
@ -1260,8 +1261,11 @@ USBPORT_ReopenPipe(IN PDEVICE_OBJECT FdoDevice,
KeReleaseSpinLockFromDpcLevel(&FdoExtension->MiniportSpinLock); KeReleaseSpinLockFromDpcLevel(&FdoExtension->MiniportSpinLock);
} }
else
{
KeReleaseSpinLockFromDpcLevel(&Endpoint->StateChangeSpinLock);
}
KeReleaseSpinLockFromDpcLevel(&Endpoint->StateChangeSpinLock);
KeReleaseSpinLock(&Endpoint->EndpointSpinLock, Endpoint->EndpointOldIrql); KeReleaseSpinLock(&Endpoint->EndpointSpinLock, Endpoint->EndpointOldIrql);
} }