Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-29 18:48:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

- Fix memory corruption when reading binary data

Browse source 
svn path=/trunk/; revision=40773
This commit is contained in:
Cameron Gutman 2009-05-02 20:46:50 +00:00
parent ce4f81375e
commit e32b96e4aa
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
reactos/drivers/network/ndis/ndis/config.c
View file

@ -615,14 +615,24 @@ NdisReadConfiguration(
return; return;
} }
(*ParameterValue)->ParameterData.BinaryData.Buffer = ExAllocatePool(PagedPool, KeyInformation->DataLength);
if (!(*ParameterValue)->ParameterData.BinaryData.Buffer)
{
NDIS_DbgPrint(MIN_TRACE,("Insufficient resources.\n"));
ExFreePool(KeyInformation);
*Status = NDIS_STATUS_RESOURCES;
return;
}
(*ParameterValue)->ParameterType = ParameterType;
(*ParameterValue)->ParameterData.BinaryData.Length = KeyInformation->DataLength;
memcpy((*ParameterValue)->ParameterData.BinaryData.Buffer, KeyInformation->Data, KeyInformation->DataLength);
MiniportResource->ResourceType = 0; MiniportResource->ResourceType = 0;
MiniportResource->Resource = *ParameterValue; MiniportResource->Resource = *ParameterValue;
NDIS_DbgPrint(MID_TRACE,("inserting 0x%x into the resource list\n", MiniportResource->Resource)); NDIS_DbgPrint(MID_TRACE,("inserting 0x%x into the resource list\n", MiniportResource->Resource));
ExInterlockedInsertTailList(&ConfigurationContext->ResourceListHead, &MiniportResource->ListEntry, &ConfigurationContext->ResourceLock); ExInterlockedInsertTailList(&ConfigurationContext->ResourceListHead, &MiniportResource->ListEntry, &ConfigurationContext->ResourceLock);
(*ParameterValue)->ParameterType = ParameterType;
memcpy(&((*ParameterValue)->ParameterData.BinaryData), KeyInformation->Data, KeyInformation->DataLength);
ExFreePool(KeyInformation); ExFreePool(KeyInformation);
*Status = NDIS_STATUS_SUCCESS; *Status = NDIS_STATUS_SUCCESS;