From e21fa420f0c22fb2ab6b0c421ce35dcedc4ba38c Mon Sep 17 00:00:00 2001 From: Pierre Schweitzer Date: Sat, 24 Oct 2015 08:49:08 +0000 Subject: [PATCH] [LSASRV] Initialize pointers addresses before the first goto, to avoid uninit addresses handling CID 1206997, 1206998 svn path=/trunk/; revision=69665 --- reactos/dll/win32/lsasrv/authpackage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/reactos/dll/win32/lsasrv/authpackage.c b/reactos/dll/win32/lsasrv/authpackage.c index 8122ad251fc..60eb2ada170 100644 --- a/reactos/dll/win32/lsasrv/authpackage.c +++ b/reactos/dll/win32/lsasrv/authpackage.c @@ -1029,6 +1029,9 @@ LsapAddSamGroups( for (i = 0; i < TokenInfo1->Groups->GroupCount; i++) SidArray.Sids[i + 1].SidPointer = TokenInfo1->Groups->Groups[i].Sid; + BuiltinMembership.Element = NULL; + AccountMembership.Element = NULL; + Status = SamIConnect(NULL, &ServerHandle, SAM_SERVER_CONNECT | SAM_SERVER_LOOKUP_DOMAIN, @@ -1059,7 +1062,6 @@ LsapAddSamGroups( goto done; } - BuiltinMembership.Element = NULL; Status = SamrGetAliasMembership(BuiltinDomainHandle, &SidArray, &BuiltinMembership); @@ -1069,7 +1071,6 @@ LsapAddSamGroups( goto done; } - AccountMembership.Element = NULL; Status = SamrGetAliasMembership(AccountDomainHandle, &SidArray, &AccountMembership);