Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-04 04:26:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WINESYNC] msi: Handle the remote case directly in MsiGetPropertyA().

Browse source 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 84d972010fcf7bc94534c7bb20890ce88381f943 by Zebediah Figura <z.figura12@gmail.com>
This commit is contained in:
winesync 2022-03-12 15:12:16 +01:00 committed by Mark Jansen
parent 0b125236c6
commit e12fb5036c
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
2 changed files with 48 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
dll/win32/msi/package.c
View file

@ -2417,22 +2417,58 @@ static UINT MSI_GetProperty( MSIHANDLE handle, LPCWSTR name,
return r;
}
UINT WINAPI MsiGetPropertyA( MSIHANDLE hInstall, LPCSTR szName,
LPSTR szValueBuf, LPDWORD pchValueBuf )
UINT WINAPI MsiGetPropertyA(MSIHANDLE hinst, const char *name, char *buf, DWORD *sz)
{
MSIPACKAGE *package;
awstring val;
LPWSTR name;
WCHAR *nameW;
UINT r;
val.unicode = FALSE;
val.str.a = szValueBuf;
if (!name)
return ERROR_INVALID_PARAMETER;
name = strdupAtoW( szName );
if (szName && !name)
if (!(nameW = strdupAtoW(name)))
return ERROR_OUTOFMEMORY;
r = MSI_GetProperty( hInstall, name, &val, pchValueBuf );
msi_free( name );
package = msihandle2msiinfo(hinst, MSIHANDLETYPE_PACKAGE);
if (!package)
{
WCHAR *value = NULL, *tmp;
MSIHANDLE remote;
DWORD len;
if (!(remote = msi_get_remote(hinst)))
return ERROR_INVALID_HANDLE;
r = remote_GetProperty(remote, nameW, &value, &len);
if (!r)
{
/* String might contain embedded nulls.
* Native returns the correct size but truncates the string. */
tmp = heap_alloc_zero((len + 1) * sizeof(WCHAR));
if (!tmp)
{
midl_user_free(value);
return ERROR_OUTOFMEMORY;
}
strcpyW(tmp, value);
r = msi_strncpyWtoA(tmp, len, buf, sz, TRUE);
heap_free(tmp);
}
midl_user_free(value);
heap_free(nameW);
return r;
}
val.unicode = FALSE;
val.str.a = buf;
r = MSI_GetProperty(hinst, nameW, &val, sz);
heap_free(nameW);
msiobj_release(&package->hdr);
return r;
}

6
modules/rostests/winetests/msi/custom.c
View file

@ -168,21 +168,21 @@ static void test_props(MSIHANDLE hinst)
r = MsiGetPropertyA(hinst, "boo", buffer, &sz);
ok(hinst, r == ERROR_MORE_DATA, "got %u\n", r);
ok(hinst, !strcmp(buffer, "q"), "got \"%s\"\n", buffer);
todo_wine_ok(hinst, sz == 6, "got size %u\n", sz);
ok(hinst, sz == 6, "got size %u\n", sz);
sz = 1;
strcpy(buffer,"x");
r = MsiGetPropertyA(hinst, "boo", buffer, &sz);
ok(hinst, r == ERROR_MORE_DATA, "got %u\n", r);
ok(hinst, !buffer[0], "got \"%s\"\n", buffer);
todo_wine_ok(hinst, sz == 6, "got size %u\n", sz);
ok(hinst, sz == 6, "got size %u\n", sz);
sz = 3;
strcpy(buffer,"x");
r = MsiGetPropertyA(hinst, "boo", buffer, &sz);
ok(hinst, r == ERROR_MORE_DATA, "got %u\n", r);
ok(hinst, !strcmp(buffer, "xy"), "got \"%s\"\n", buffer);
todo_wine_ok(hinst, sz == 6, "got size %u\n", sz);
ok(hinst, sz == 6, "got size %u\n", sz);
sz = 4;
strcpy(buffer,"x");