From e00840033e9563bdc8f6da73db07028286b4d9bc Mon Sep 17 00:00:00 2001 From: Giannis Adamopoulos Date: Thu, 22 Sep 2016 16:09:28 +0000 Subject: [PATCH] [SHELL32] - HCR_GetFolderAttributes already calls GetAttributesOf when needed, calling it when it is not needed can lead to crashes. svn path=/trunk/; revision=72769 --- reactos/dll/win32/shell32/folders/CRegFolder.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/reactos/dll/win32/shell32/folders/CRegFolder.cpp b/reactos/dll/win32/shell32/folders/CRegFolder.cpp index 5663a581c67..df9e1d1e919 100644 --- a/reactos/dll/win32/shell32/folders/CRegFolder.cpp +++ b/reactos/dll/win32/shell32/folders/CRegFolder.cpp @@ -180,15 +180,6 @@ HRESULT CRegFolder::GetGuidItemAttributes (LPCITEMIDLIST pidl, LPDWORD pdwAttrib { return S_OK; } - else - { - /* If we can't get it from the registry we have to query the child */ - CComPtr psf2; - if (SUCCEEDED(BindToObject(pidl, 0, IID_PPV_ARG(IShellFolder, &psf2)))) - { - return psf2->GetAttributesOf(0, NULL, pdwAttributes); - } - } *pdwAttributes &= SFGAO_CANLINK; return S_OK;