Cleaning up victims of stricter warning checking...

svn path=/trunk/; revision=4107

reactos/lib/advapi32/misc/dllmain.c

@@ -1,4 +1,4 @@
-/* $Id: dllmain.c,v 1.6 2002/09/08 10:22:36 chorns Exp $
+/* $Id: dllmain.c,v 1.7 2003/02/02 19:26:07 hyperion Exp $
  *
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
@@ -15,6 +15,8 @@
 #define NDEBUG
 #include <debug.h>
 
+extern BOOL RegInitialize(VOID);
+extern BOOL RegCleanup(VOID);
 
 INT STDCALL
 DllMain(PVOID hinstDll,

reactos/lib/advapi32/misc/shutdown.c

@@ -1,4 +1,4 @@
-/* $Id: shutdown.c,v 1.8 2003/02/02 17:20:51 ekohl Exp $
+/* $Id: shutdown.c,v 1.9 2003/02/02 19:27:16 hyperion Exp $
  *
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:     ReactOS system libraries
@@ -24,8 +24,6 @@ WINBOOL
 STDCALL
 AbortSystemShutdownW(LPCWSTR lpMachineName)
 {
-    NTSTATUS Status;
-
     SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
     return FALSE;
 }

reactos/lib/advapi32/reg/reg.c

@@ -1,4 +1,4 @@
-/* $Id: reg.c,v 1.21 2002/12/08 16:14:28 robd Exp $
+/* $Id: reg.c,v 1.22 2003/02/02 19:27:16 hyperion Exp $
  *
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
@@ -105,7 +105,7 @@ static NTSTATUS OpenCurrentConfigKey(PHANDLE KeyHandle);
 
 /* FUNCTIONS *****************************************************************/
 
-inline RegiTerminateWideString(LPWSTR String, DWORD Length)
+inline void RegiTerminateWideString(LPWSTR String, DWORD Length)
 {
   LPWSTR AfterString = String + Length;
   *AfterString = 0;

reactos/lib/advapi32/service/scm.c

@@ -1,4 +1,4 @@
-/* $Id: scm.c,v 1.15 2002/12/27 14:40:03 robd Exp $
+/* $Id: scm.c,v 1.16 2003/02/02 19:27:16 hyperion Exp $
  * 
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
@@ -15,6 +15,7 @@
 #define NTOS_MODE_USER
 #include <ntos.h>
 #include <windows.h>
+#include <wchar.h>
 #include <tchar.h>
 
 #define DBG

reactos/lib/advapi32/service/sctrl.c

@@ -1,4 +1,4 @@
-/* $Id: sctrl.c,v 1.8 2002/11/14 18:21:04 chorns Exp $
+/* $Id: sctrl.c,v 1.9 2003/02/02 19:27:17 hyperion Exp $
  * 
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
@@ -15,6 +15,8 @@
 #define NTOS_MODE_USER
 #include <ntos.h>
 #include <windows.h>
+#include <string.h>
+#include <wchar.h>
 
 #define NDEBUG
 #include <debug.h>
@@ -35,7 +37,7 @@ typedef struct
 
 static ULONG ActiveServiceCount;
 static PACTIVE_SERVICE ActiveServices;
-static PHANDLE ActiveServicesThreadHandles;
+/* static PHANDLE ActiveServicesThreadHandles; */ /* uncomment when in use */
 
 /* FUNCTIONS *****************************************************************/
 
@@ -315,9 +317,6 @@ BOOL STDCALL
 StartServiceCtrlDispatcherW(LPSERVICE_TABLE_ENTRYW lpServiceStartTable)
 {
   ULONG i;
-  HANDLE h;
-  DWORD Tid;
-  DWORD r;
   HANDLE hPipe;
   DWORD dwError;
 
@@ -347,7 +346,7 @@ StartServiceCtrlDispatcherW(LPSERVICE_TABLE_ENTRYW lpServiceStartTable)
     }
 
   dwError = ScConnectControlPipe(&hPipe);
-  if (dwError = ERROR_SUCCESS)
+  if (dwError == ERROR_SUCCESS)
     {
       /* FIXME: free the service table */
       return(FALSE);

reactos/lib/gdi32/objects/region.c

@@ -56,7 +56,7 @@ CreateRectRgnIndirect(
 	CONST RECT	*a0
 	)
 {
-	return W32kCreateRectRgnIndirect(a0);
+	return W32kCreateRectRgnIndirect((RECT *)a0);
 }
 
 

reactos/lib/gdi32/objects/text.c

@@ -3,6 +3,7 @@
 #endif
 
 #undef WIN32_LEAN_AND_MEAN
+#include <string.h>
 #include <windows.h>
 #include <ddk/ntddk.h>
 #include <win32k/kapi.h>
@@ -202,7 +203,6 @@ CreateFontA(
         ANSI_STRING StringA;
         UNICODE_STRING StringU;
 	HFONT ret;
-        LOGFONT tlf;
 
 	RtlInitAnsiString(&StringA, (LPSTR)Face);
 	RtlAnsiStringToUnicodeString(&StringU, &StringA, TRUE);

reactos/lib/msafd/misc/dllmain.c

@@ -7,6 +7,7 @@
  * REVISIONS:
  *   CSH 01/09-2000 Created
  */
+#include <string.h>
 #include <msafd.h>
 #include <helpers.h>
 

reactos/lib/msafd/misc/sndrcv.c

@@ -7,6 +7,7 @@
  * REVISIONS:
  *   CSH 01/09-2000 Created
  */
+#include <string.h>
 #include <msafd.h>
 
 INT

reactos/lib/psapi/misc/win32.c

@@ -1,4 +1,4 @@
-/* $Id: win32.c,v 1.4 2002/08/31 17:11:24 hyperion Exp $
+/* $Id: win32.c,v 1.5 2003/02/02 19:26:08 hyperion Exp $
  */
 /*
  * COPYRIGHT:   See COPYING in the top level directory
@@ -165,6 +165,15 @@ NTSTATUS STDCALL EnumProcessesCallback
 }
 
 /* exported interface */
+/*
+ @brief Enumerate the process identifiers of the currently active processes
+
+ @param lpidProcess Array that receives the list of process identifiers
+ @param cb          Size of the @p lpidProcess array, in bytes
+ @param lpcbNeeded  Number of bytes returned in the @p lpidProcess array
+
+ @return [standard]
+ */
 BOOL STDCALL EnumProcesses
 (
  DWORD *lpidProcess,

reactos/lib/ws2_32/misc/catalog.c

@@ -155,7 +155,6 @@ PCATALOG_ENTRY LocateProviderById(
 {
   PLIST_ENTRY CurrentEntry;
   PCATALOG_ENTRY Provider;
-  UINT i;
 
   WS_DbgPrint(MAX_TRACE, ("CatalogEntryId (%d).\n", CatalogEntryId));
 

reactos/lib/ws2_32/misc/dllmain.c

@@ -288,7 +288,6 @@ select(
   PCATALOG_ENTRY Provider;
   INT Count;
   INT Errno;
-  ULONG i;
 
   WS_DbgPrint(MAX_TRACE, ("readfds (0x%X)  writefds (0x%X)  exceptfds (0x%X).\n",
     readfds, writefds, exceptfds));

reactos/lib/ws2_32/misc/event.c

@@ -176,7 +176,6 @@ WSAEventSelect(
   PCATALOG_ENTRY Provider;
   INT Status;
   INT Errno;
-  LONG i;
 
   if (!WSAINITIALIZED) {
     WSASetLastError(WSANOTINITIALISED);

reactos/lib/ws2_32/misc/sndrcv.c

@@ -9,6 +9,7 @@
  */
 #include <ws2_32.h>
 #include <catalog.h>
+#include <handle.h>
 
 INT
 EXPORT

reactos/lib/ws2_32/misc/upcall.c

@@ -9,6 +9,7 @@
  */
 #include <ws2_32.h>
 #include <catalog.h>
+#include <handle.h>
 
 BOOL
 WSPAPI
@@ -118,7 +119,7 @@ WPUModifyIFSHandle(
   }
 
   Socket = (SOCKET)CreateProviderHandle(
-    ProposedHandle,
+    (HANDLE)ProposedHandle,
     Provider);
 
   *lpErrno = NO_ERROR;