From dadc6894650ce511861c397afceebf5cabebb4ab Mon Sep 17 00:00:00 2001 From: Royce Mitchell III Date: Fri, 11 Jul 2003 15:59:37 +0000 Subject: [PATCH] @implemented and @unimplemented comments for subsys/win32k svn path=/trunk/; revision=5077 --- reactos/subsys/win32k/eng/bitblt.c | 7 +++++-- reactos/subsys/win32k/eng/brush.c | 8 +++++++- reactos/subsys/win32k/eng/clip.c | 14 +++++++++++++- reactos/subsys/win32k/eng/copybits.c | 8 ++++++-- reactos/subsys/win32k/eng/debug.c | 5 ++++- reactos/subsys/win32k/eng/device.c | 5 ++++- reactos/subsys/win32k/eng/lineto.c | 5 ++++- reactos/subsys/win32k/eng/mem.c | 20 +++++++++++++++++++- reactos/subsys/win32k/eng/nls.c | 11 ++++++++++- reactos/subsys/win32k/eng/paint.c | 5 ++++- reactos/subsys/win32k/eng/palette.c | 11 ++++++++++- reactos/subsys/win32k/eng/perfcnt.c | 8 +++++++- reactos/subsys/win32k/eng/surface.c | 26 +++++++++++++++++++++++++- reactos/subsys/win32k/eng/xlate.c | 11 ++++++++++- reactos/subsys/win32k/ldr/loader.c | 8 +++++++- reactos/subsys/win32k/misc/math.c | 6 +++++- 16 files changed, 140 insertions(+), 18 deletions(-) diff --git a/reactos/subsys/win32k/eng/bitblt.c b/reactos/subsys/win32k/eng/bitblt.c index 1e909f29c46..ecd490536a2 100644 --- a/reactos/subsys/win32k/eng/bitblt.c +++ b/reactos/subsys/win32k/eng/bitblt.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: bitblt.c,v 1.22 2003/07/09 07:00:00 gvg Exp $ +/* $Id: bitblt.c,v 1.23 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -180,6 +180,9 @@ CallDibBitBlt(PSURFOBJ OutputObj, INT abs(INT nm); +/* + * @unimplemented + */ BOOL STDCALL EngBitBlt(SURFOBJ *DestObj, SURFOBJ *SourceObj, @@ -298,7 +301,7 @@ EngBitBlt(SURFOBJ *DestObj, OutputGDI = (PSURFGDI)AccessInternalObjectFromUserObject(OutputObj); } - /* The code currently assumes there will be a source bitmap. This is not true when, for example, using this function to + /* FIXME The code currently assumes there will be a source bitmap. This is not true when, for example, using this function to * paint a brush pattern on the destination. */ if (NULL == InputObj && 0xaacc != Rop4 && PATCOPY != Rop4) { diff --git a/reactos/subsys/win32k/eng/brush.c b/reactos/subsys/win32k/eng/brush.c index 84e86045a7d..cb0a1eea77a 100644 --- a/reactos/subsys/win32k/eng/brush.c +++ b/reactos/subsys/win32k/eng/brush.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: brush.c,v 1.7 2003/05/18 17:16:17 ea Exp $ +/* $Id: brush.c,v 1.8 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -29,6 +29,9 @@ #include +/* + * @implemented + */ PVOID STDCALL BRUSHOBJ_pvAllocRbrush(IN PBRUSHOBJ BrushObj, IN ULONG ObjSize) @@ -37,6 +40,9 @@ BRUSHOBJ_pvAllocRbrush(IN PBRUSHOBJ BrushObj, return(BrushObj->pvRbrush); } +/* + * @implemented + */ PVOID STDCALL BRUSHOBJ_pvGetRbrush(IN PBRUSHOBJ BrushObj) { diff --git a/reactos/subsys/win32k/eng/clip.c b/reactos/subsys/win32k/eng/clip.c index eed1ad0dfd5..34bafb3f65e 100644 --- a/reactos/subsys/win32k/eng/clip.c +++ b/reactos/subsys/win32k/eng/clip.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: clip.c,v 1.12 2003/05/18 17:16:17 ea Exp $ +/* $Id: clip.c,v 1.13 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -92,18 +92,27 @@ CLIPOBJ STDCALL * IntEngCreateClipRegion( ULONG count, PRECTL pRect, RECTL rcBou return NULL; } +/* + * @implemented + */ CLIPOBJ * STDCALL EngCreateClip(VOID) { return EngAllocMem(FL_ZERO_MEMORY, sizeof(CLIPOBJ), 0); } +/* + * @implemented + */ VOID STDCALL EngDeleteClip(CLIPOBJ *ClipRegion) { EngFreeMem(ClipRegion); } +/* + * @unimplemented + */ ULONG STDCALL CLIPOBJ_cEnumStart(IN PCLIPOBJ ClipObj, IN BOOL ShouldDoAll, @@ -130,6 +139,9 @@ CLIPOBJ_cEnumStart(IN PCLIPOBJ ClipObj, return ClipGDI->EnumRects.c; } +/* + * @implemented + */ BOOL STDCALL CLIPOBJ_bEnum(IN PCLIPOBJ ClipObj, IN ULONG ObjSize, diff --git a/reactos/subsys/win32k/eng/copybits.c b/reactos/subsys/win32k/eng/copybits.c index ae131b7560f..53d6a18773c 100644 --- a/reactos/subsys/win32k/eng/copybits.c +++ b/reactos/subsys/win32k/eng/copybits.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: copybits.c,v 1.14 2003/05/18 17:16:17 ea Exp $ +/* $Id: copybits.c,v 1.15 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -36,6 +36,9 @@ #include #include +/* + * @unimplemented + */ BOOL STDCALL EngCopyBits(SURFOBJ *Dest, SURFOBJ *Source, @@ -175,7 +178,8 @@ EngCopyBits(SURFOBJ *Dest, } while(EnumMore); - MouseSafetyOnDrawEnd(Source, SourceGDI); + MouseSafetyOnDrawEnd(Source, SourceGDI); + MouseSafetyOnDrawEnd(Dest, DestGDI); return(TRUE); diff --git a/reactos/subsys/win32k/eng/debug.c b/reactos/subsys/win32k/eng/debug.c index b5f017a4f1b..8f544b2faad 100644 --- a/reactos/subsys/win32k/eng/debug.c +++ b/reactos/subsys/win32k/eng/debug.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: debug.c,v 1.4 2003/05/18 17:16:17 ea Exp $ +/* $Id: debug.c,v 1.5 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -29,6 +29,9 @@ #include +/* + * @implemented + */ VOID STDCALL EngDebugPrint(PCHAR StandardPrefix, PCHAR DebugMessage, diff --git a/reactos/subsys/win32k/eng/device.c b/reactos/subsys/win32k/eng/device.c index 822da1b4952..fdebed7fae1 100644 --- a/reactos/subsys/win32k/eng/device.c +++ b/reactos/subsys/win32k/eng/device.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: device.c,v 1.8 2003/06/21 14:25:30 gvg Exp $ +/* $Id: device.c,v 1.9 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -33,6 +33,9 @@ #define NDEBUG #include +/* + * @implemented + */ DWORD STDCALL EngDeviceIoControl(HANDLE hDevice, DWORD dwIoControlCode, diff --git a/reactos/subsys/win32k/eng/lineto.c b/reactos/subsys/win32k/eng/lineto.c index 53e01dcc3c9..fe0780a5d4f 100644 --- a/reactos/subsys/win32k/eng/lineto.c +++ b/reactos/subsys/win32k/eng/lineto.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: lineto.c,v 1.18 2003/05/18 17:16:17 ea Exp $ */ +/* $Id: lineto.c,v 1.19 2003/07/11 15:59:37 royce Exp $ */ #include #include #include @@ -29,6 +29,9 @@ #include #include +/* + * @unimplemented + */ BOOL STDCALL EngLineTo(SURFOBJ *DestObj, CLIPOBJ *Clip, diff --git a/reactos/subsys/win32k/eng/mem.c b/reactos/subsys/win32k/eng/mem.c index 24042bc6bae..8c9f7b1c606 100644 --- a/reactos/subsys/win32k/eng/mem.c +++ b/reactos/subsys/win32k/eng/mem.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: mem.c,v 1.10 2003/06/19 17:13:28 gvg Exp $ +/* $Id: mem.c,v 1.11 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -41,6 +41,9 @@ typedef struct _USERMEMHEADER } USERMEMHEADER, *PUSERMEMHEADER; +/* + * @implemented + */ PVOID STDCALL EngAllocMem(ULONG Flags, ULONG MemSize, @@ -58,12 +61,18 @@ EngAllocMem(ULONG Flags, return newMem; } +/* + * @implemented + */ VOID STDCALL EngFreeMem(PVOID Mem) { ExFreePool(Mem); } +/* + * @implemented + */ PVOID STDCALL EngAllocUserMem(ULONG cj, ULONG Tag) { @@ -86,6 +95,9 @@ EngAllocUserMem(ULONG cj, ULONG Tag) return (PVOID)(Header + 1); } +/* + * @implemented + */ VOID STDCALL EngFreeUserMem(PVOID pv) { @@ -95,12 +107,18 @@ EngFreeUserMem(PVOID pv) ZwFreeVirtualMemory(NtCurrentProcess(), (PVOID *) &Header, &MemSize, MEM_DECOMMIT); } +/* + * @implemented + */ HANDLE STDCALL EngSecureMem(PVOID Address, ULONG Length) { return MmSecureVirtualMemory(Address, Length, PAGE_READWRITE); } +/* + * @implemented + */ VOID STDCALL EngUnsecureMem(HANDLE Mem) { diff --git a/reactos/subsys/win32k/eng/nls.c b/reactos/subsys/win32k/eng/nls.c index 086b8867641..6f6a25dd713 100644 --- a/reactos/subsys/win32k/eng/nls.c +++ b/reactos/subsys/win32k/eng/nls.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: nls.c,v 1.1 2003/06/21 18:04:49 ekohl Exp $ +/* $Id: nls.c,v 1.2 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -35,6 +35,9 @@ /* FUNCTIONS ****************************************************************/ +/* + * @implemented + */ VOID STDCALL EngGetCurrentCodePage(OUT PUSHORT OemCodePage, OUT PUSHORT AnsiCodePage) @@ -43,6 +46,9 @@ EngGetCurrentCodePage(OUT PUSHORT OemCodePage, AnsiCodePage); } +/* + * @implemented + */ VOID STDCALL EngMultiByteToUnicodeN(OUT LPWSTR UnicodeString, IN ULONG MaxBytesInUnicodeString, @@ -57,6 +63,9 @@ EngMultiByteToUnicodeN(OUT LPWSTR UnicodeString, BytesInMultiByteString); } +/* + * @implemented + */ VOID STDCALL EngUnicodeToMultiByteN(OUT PCHAR MultiByteString, IN ULONG MaxBytesInMultiByteString, diff --git a/reactos/subsys/win32k/eng/paint.c b/reactos/subsys/win32k/eng/paint.c index d2afd7eac7f..6b0d04ee0c1 100644 --- a/reactos/subsys/win32k/eng/paint.c +++ b/reactos/subsys/win32k/eng/paint.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: paint.c,v 1.14 2003/05/18 17:16:17 ea Exp $ +/* $Id: paint.c,v 1.15 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -102,6 +102,9 @@ EngPaintRgn(SURFOBJ *Surface, CLIPOBJ *ClipRegion, ULONG iColor, MIX Mix, } } +/* + * @unimplemented + */ BOOL STDCALL EngPaint(IN SURFOBJ *Surface, IN CLIPOBJ *ClipRegion, diff --git a/reactos/subsys/win32k/eng/palette.c b/reactos/subsys/win32k/eng/palette.c index edd7e995622..c2ae93cb7c3 100644 --- a/reactos/subsys/win32k/eng/palette.c +++ b/reactos/subsys/win32k/eng/palette.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: palette.c,v 1.15 2003/05/18 17:16:17 ea Exp $ +/* $Id: palette.c,v 1.16 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -34,6 +34,9 @@ #define NDEBUG #include +/* + * @implemented + */ HPALETTE STDCALL EngCreatePalette(ULONG Mode, ULONG NumColors, @@ -74,6 +77,9 @@ EngCreatePalette(ULONG Mode, return NewPalette; } +/* + * @implemented + */ BOOL STDCALL EngDeletePalette(IN HPALETTE Palette) { @@ -81,6 +87,9 @@ EngDeletePalette(IN HPALETTE Palette) return TRUE; } +/* + * @implemented + */ ULONG STDCALL PALOBJ_cGetColors(PALOBJ *PalObj, ULONG Start, diff --git a/reactos/subsys/win32k/eng/perfcnt.c b/reactos/subsys/win32k/eng/perfcnt.c index d670cfe6f3c..d93a25060e8 100644 --- a/reactos/subsys/win32k/eng/perfcnt.c +++ b/reactos/subsys/win32k/eng/perfcnt.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: perfcnt.c,v 1.2 2003/06/20 10:37:23 gvg Exp $ +/* $Id: perfcnt.c,v 1.3 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -31,6 +31,9 @@ #include #include +/* + * @implemented + */ VOID STDCALL EngQueryPerformanceFrequency(LONGLONG *Frequency) { @@ -40,6 +43,9 @@ EngQueryPerformanceFrequency(LONGLONG *Frequency) *Frequency = Freq.QuadPart; } +/* + * @implemented + */ VOID STDCALL EngQueryPerformanceCounter(LONGLONG *Count) { diff --git a/reactos/subsys/win32k/eng/surface.c b/reactos/subsys/win32k/eng/surface.c index c78883b2e88..abe01dcb1f7 100644 --- a/reactos/subsys/win32k/eng/surface.c +++ b/reactos/subsys/win32k/eng/surface.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: surface.c,v 1.19 2003/05/18 17:16:17 ea Exp $ +/* $Id: surface.c,v 1.20 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -141,6 +141,9 @@ VOID FASTCALL InitializeFuncs(SURFGDI *SurfGDI, ULONG BitmapFormat) } } +/* + * @implemented + */ HBITMAP STDCALL EngCreateDeviceBitmap(IN DHSURF dhsurf, IN SIZEL Size, @@ -156,6 +159,9 @@ EngCreateDeviceBitmap(IN DHSURF dhsurf, return NewBitmap; } +/* + * @implemented + */ HBITMAP STDCALL EngCreateBitmap(IN SIZEL Size, IN LONG Width, @@ -214,6 +220,9 @@ EngCreateBitmap(IN SIZEL Size, return NewBitmap; } +/* + * @unimplemented + */ HSURF STDCALL EngCreateDeviceSurface(IN DHSURF dhsurf, IN SIZEL Size, @@ -257,6 +266,9 @@ PFN FASTCALL DriverFunction(DRVENABLEDATA *DED, ULONG DriverFunc) return NULL; } +/* + * @implemented + */ BOOL STDCALL EngAssociateSurface(IN HSURF Surface, IN HDEV Dev, @@ -296,6 +308,9 @@ EngAssociateSurface(IN HSURF Surface, return TRUE; } +/* + * @implemented + */ BOOL STDCALL EngDeleteSurface(IN HSURF Surface) { @@ -303,6 +318,9 @@ EngDeleteSurface(IN HSURF Surface) return TRUE; } +/* + * @implemented + */ BOOL STDCALL EngEraseSurface(SURFOBJ *Surface, RECTL *Rect, @@ -311,6 +329,9 @@ EngEraseSurface(SURFOBJ *Surface, return FillSolid(Surface, Rect, iColor); } +/* + * @unimplemented + */ SURFOBJ * STDCALL EngLockSurface(IN HSURF Surface) { @@ -318,6 +339,9 @@ EngLockSurface(IN HSURF Surface) return (SURFOBJ*)AccessUserObject((ULONG)Surface); } +/* + * @unimplemented + */ VOID STDCALL EngUnlockSurface(IN SURFOBJ *Surface) { diff --git a/reactos/subsys/win32k/eng/xlate.c b/reactos/subsys/win32k/eng/xlate.c index eb1a5fd21bd..184fc1d4a82 100644 --- a/reactos/subsys/win32k/eng/xlate.c +++ b/reactos/subsys/win32k/eng/xlate.c @@ -16,7 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: xlate.c,v 1.19 2003/05/18 17:16:17 ea Exp $ +/* $Id: xlate.c,v 1.20 2003/07/11 15:59:37 royce Exp $ * * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -356,6 +356,9 @@ VOID FASTCALL EngDeleteXlate(XLATEOBJ *XlateObj) FreeGDIHandle((ULONG)HXlate); } +/* + * @implemented + */ ULONG * STDCALL XLATEOBJ_piVector(XLATEOBJ *XlateObj) { @@ -369,6 +372,9 @@ XLATEOBJ_piVector(XLATEOBJ *XlateObj) return NULL; } +/* + * @unimplemented + */ ULONG STDCALL XLATEOBJ_iXlate(XLATEOBJ *XlateObj, ULONG Color) @@ -406,6 +412,9 @@ XLATEOBJ_iXlate(XLATEOBJ *XlateObj, return 0; } +/* + * @implemented + */ ULONG STDCALL XLATEOBJ_cGetPalette(XLATEOBJ *XlateObj, ULONG PalOutType, diff --git a/reactos/subsys/win32k/ldr/loader.c b/reactos/subsys/win32k/ldr/loader.c index d647612ddfd..eab837173c3 100644 --- a/reactos/subsys/win32k/ldr/loader.c +++ b/reactos/subsys/win32k/ldr/loader.c @@ -16,13 +16,16 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -/* $Id: loader.c,v 1.10 2003/05/18 17:16:17 ea Exp $ +/* $Id: loader.c,v 1.11 2003/07/11 15:59:37 royce Exp $ * */ #include #include +/* + * @implemented + */ HANDLE STDCALL EngLoadImage (LPWSTR DriverName) @@ -38,6 +41,9 @@ EngLoadImage (LPWSTR DriverName) } +/* + * @unimplemented + */ HANDLE STDCALL EngLoadModule(LPWSTR ModuleName) diff --git a/reactos/subsys/win32k/misc/math.c b/reactos/subsys/win32k/misc/math.c index ca4c6595c43..41388342aca 100644 --- a/reactos/subsys/win32k/misc/math.c +++ b/reactos/subsys/win32k/misc/math.c @@ -237,7 +237,11 @@ int mod(int num, int denom) return dvt.rem; } -//FIXME! Is there a better algorithm. like FT_MulDiv +/* + * FIXME! Is there a better algorithm. like FT_MulDiv + * + * @implemented + */ INT STDCALL EngMulDiv( INT nMultiplicand, INT nMultiplier,