Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-06-18 17:15:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

[BROWSEUI] Remove useless RegenerateUserEnvironment() call.

Browse source 
[SHELL32]  Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
This commit is contained in:
Hermès Bélusca-Maïto 2019-12-29 15:48:42 +01:00
parent a8e7defb01
commit d967b5aa25
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
2 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
dll/win32/browseui/shellbrowser.cpp
View file

@ -3558,9 +3558,6 @@ LRESULT CShellBrowser::RelayMsgToShellView(UINT uMsg, WPARAM wParam, LPARAM lPar
LRESULT CShellBrowser::OnSettingChange(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) LRESULT CShellBrowser::OnSettingChange(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled)
{ {
LPVOID lpEnvironment;
RegenerateUserEnvironment(&lpEnvironment, TRUE);
SHPropagateMessage(m_hWnd, uMsg, wParam, lParam, TRUE); SHPropagateMessage(m_hWnd, uMsg, wParam, lParam, TRUE);
return 0; return 0;
} }

8
dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp
View file

@ -390,8 +390,12 @@ LRESULT CDesktopBrowser::OnSize(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &b
LRESULT CDesktopBrowser::OnSettingChange(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) LRESULT CDesktopBrowser::OnSettingChange(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled)
{ {
LPVOID lpEnvironment; if (uMsg == WM_SETTINGCHANGE /* == WM_WININICHANGE */ &&
RegenerateUserEnvironment(&lpEnvironment, TRUE); lstrcmpiW((LPCWSTR)lParam, L"Environment") == 0)
{
LPVOID lpEnvironment;
RegenerateUserEnvironment(&lpEnvironment, TRUE);
}
if (m_hWndShellView) if (m_hWndShellView)
{ {