Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-11-10 16:48:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SERVICES]

Browse source 
- Do not use an unsigned type for a value that can become negative in ScmAssignNewTag (CID 14665)

svn path=/trunk/; revision=54482
This commit is contained in:
Thomas Faber 2011-11-23 18:15:26 +00:00
parent 494f949f52
commit d87dae2daa
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
reactos/base/system/services/rpcserver.c
View file

@ -271,7 +271,7 @@ ScmAssignNewTag(PSERVICE lpService)
DWORD dwFreeTag = 0;
DWORD dwTagUsedBase = 1;
BOOLEAN TagUsed[TAG_ARRAY_SIZE];
DWORD dwTagOffset;
INT nTagOffset;
DWORD i;
DWORD cbDataSize;
PLIST_ENTRY ServiceEntry;
@ -333,9 +333,9 @@ findFreeTag:
/* mark tags in GroupOrderList as used */
for (i = 1; i <= dwGroupTagCount; i++)
{
dwTagOffset = pdwGroupTags[i] - dwTagUsedBase;
if (dwTagOffset >= 0 && dwTagOffset < TAG_ARRAY_SIZE)
TagUsed[dwTagOffset] = TRUE;
nTagOffset = pdwGroupTags[i] - dwTagUsedBase;
if (nTagOffset >= 0 && nTagOffset < TAG_ARRAY_SIZE)
TagUsed[nTagOffset] = TRUE;
}
/* mark tags in service list as used */
@ -346,9 +346,9 @@ findFreeTag:
CurrentService = CONTAINING_RECORD(ServiceEntry, SERVICE, ServiceListEntry);
if (CurrentService->lpGroup == lpService->lpGroup)
{
dwTagOffset = CurrentService->dwTag - dwTagUsedBase;
if (dwTagOffset >= 0 && dwTagOffset < TAG_ARRAY_SIZE)
TagUsed[dwTagOffset] = TRUE;
nTagOffset = CurrentService->dwTag - dwTagUsedBase;
if (nTagOffset >= 0 && nTagOffset < TAG_ARRAY_SIZE)
TagUsed[nTagOffset] = TRUE;
}
ServiceEntry = ServiceEntry->Flink;
@ -365,8 +365,7 @@ findFreeTag:
}
dwTagUsedBase += TAG_ARRAY_SIZE;
}
while (!dwFreeTag);
} while (!dwFreeTag);
cleanup:
if (pdwGroupTags)