Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-07-13 12:24:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

- Fail if From is NULL

Browse source 
- Fixes Coverity error 652

svn path=/branches/aicom-network-fixes/; revision=36524
This commit is contained in:
Cameron Gutman 2008-09-26 03:03:55 +00:00
parent 975e8109a2
commit d8398cc719
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/network/afd/afd/tdiconn.c
View file

@ -194,6 +194,8 @@ TdiBuildConnectionInfoPair
ULONG TdiAddressSize; ULONG TdiAddressSize;
PTDI_CONNECTION_INFORMATION FromTdiConn, ToTdiConn; PTDI_CONNECTION_INFORMATION FromTdiConn, ToTdiConn;
if (!From) return STATUS_INVALID_PARAMETER;
/* FIXME: Get from socket information */ /* FIXME: Get from socket information */
TdiAddressSize = TdiAddressSizeFromType(From->Address[0].AddressType); TdiAddressSize = TdiAddressSizeFromType(From->Address[0].AddressType);
SizeOfEntry = TdiAddressSize + sizeof(TDI_CONNECTION_INFORMATION); SizeOfEntry = TdiAddressSize + sizeof(TDI_CONNECTION_INFORMATION);
@ -210,12 +212,7 @@ TdiBuildConnectionInfoPair
FromTdiConn = (PTDI_CONNECTION_INFORMATION)LayoutFrame; FromTdiConn = (PTDI_CONNECTION_INFORMATION)LayoutFrame;
ToTdiConn = (PTDI_CONNECTION_INFORMATION)LayoutFrame + SizeOfEntry; ToTdiConn = (PTDI_CONNECTION_INFORMATION)LayoutFrame + SizeOfEntry;
if (From != NULL) {
TdiBuildConnectionInfoInPlace( FromTdiConn, From ); TdiBuildConnectionInfoInPlace( FromTdiConn, From );
} else {
TdiBuildNullConnectionInfoInPlace( FromTdiConn,
From->Address[0].AddressType );
}
TdiBuildConnectionInfoInPlace( ToTdiConn, To ); TdiBuildConnectionInfoInPlace( ToTdiConn, To );