[WINDOWSCODECS] It turns out that /wd4133 is not enough to demote the error; we need to use remove_target_compile_option() to completely remove the /we4133 flag.

Addendum to commits 7e116f0e and 00ed72d7.

This removes the "error C4133: 'function': incompatible types - from
'WICPixelFormatNumericRepresentation *' to 'DWORD *'"
message that still remains even when using /wd4133 .
This commit is contained in:
Hermès Bélusca-Maïto 2020-11-06 00:17:33 +01:00
parent ce2c1f6321
commit d829bcc629
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0

View file

@ -71,9 +71,10 @@ add_library(windowscodecs MODULE
${CMAKE_CURRENT_BINARY_DIR}/windowscodecs.def)
if(MSVC)
target_compile_options(windowscodecs PRIVATE
/wd4133 # error C4133: 'function': incompatible types - from 'WICPixelFormatNumericRepresentation *' to 'DWORD *'
/FItypeof.h)
# error C4133: 'function': incompatible types - from 'WICPixelFormatNumericRepresentation *' to 'DWORD *'
remove_target_compile_option(windowscodecs "/we4133")
target_compile_options(windowscodecs PRIVATE /FItypeof.h)
endif()
set_module_type(windowscodecs win32dll)