[RTL]: Code styling modifications only:

- Use RtlCopyMemory,
- Don't hardcode types for sizeof(parameters),
- Braces for 'for'-loops,
- while (TRUE) instead of while (1),
- Use ULONG for integer iterator that cannot be negative,
- Start sentences with capitals.

svn path=/trunk/; revision=71812
This commit is contained in:
Hermès Bélusca-Maïto 2016-07-04 20:40:45 +00:00
parent 982870596b
commit d39e489c3a

View file

@ -170,10 +170,10 @@ NTAPI
RtlTimeFieldsToTime(IN PTIME_FIELDS TimeFields, RtlTimeFieldsToTime(IN PTIME_FIELDS TimeFields,
OUT PLARGE_INTEGER Time) OUT PLARGE_INTEGER Time)
{ {
int CurMonth; ULONG CurMonth;
TIME_FIELDS IntTimeFields; TIME_FIELDS IntTimeFields;
memcpy(&IntTimeFields, RtlCopyMemory(&IntTimeFields,
TimeFields, TimeFields,
sizeof(TIME_FIELDS)); sizeof(TIME_FIELDS));
@ -260,27 +260,27 @@ RtlTimeToTimeFields(IN PLARGE_INTEGER Time,
ULONGLONG IntTime = Time->QuadPart; ULONGLONG IntTime = Time->QuadPart;
/* Extract millisecond from time and convert time into seconds */ /* Extract millisecond from time and convert time into seconds */
TimeFields->Milliseconds = (CSHORT) ((IntTime % TICKSPERSEC) / TICKSPERMSEC); TimeFields->Milliseconds = (CSHORT)((IntTime % TICKSPERSEC) / TICKSPERMSEC);
IntTime = IntTime / TICKSPERSEC; IntTime = IntTime / TICKSPERSEC;
/* Split the time into days and seconds within the day */ /* Split the time into days and seconds within the day */
Days = (ULONG)(IntTime / SECSPERDAY); Days = (ULONG)(IntTime / SECSPERDAY);
SecondsInDay = IntTime % SECSPERDAY; SecondsInDay = IntTime % SECSPERDAY;
/* compute time of day */ /* Compute time of day */
TimeFields->Hour = (CSHORT) (SecondsInDay / SECSPERHOUR); TimeFields->Hour = (CSHORT)(SecondsInDay / SECSPERHOUR);
SecondsInDay = SecondsInDay % SECSPERHOUR; SecondsInDay = SecondsInDay % SECSPERHOUR;
TimeFields->Minute = (CSHORT) (SecondsInDay / SECSPERMIN); TimeFields->Minute = (CSHORT)(SecondsInDay / SECSPERMIN);
TimeFields->Second = (CSHORT) (SecondsInDay % SECSPERMIN); TimeFields->Second = (CSHORT)(SecondsInDay % SECSPERMIN);
/* compute day of week */ /* Compute day of week */
TimeFields->Weekday = (CSHORT) ((EPOCHWEEKDAY + Days) % DAYSPERWEEK); TimeFields->Weekday = (CSHORT)((EPOCHWEEKDAY + Days) % DAYSPERWEEK);
/* compute year */ /* Compute year */
CurYear = EPOCHYEAR; CurYear = EPOCHYEAR;
CurYear += Days / DAYSPERLEAPYEAR; CurYear += Days / DAYSPERLEAPYEAR;
Days -= DaysSinceEpoch(CurYear); Days -= DaysSinceEpoch(CurYear);
while (1) while (TRUE)
{ {
LeapYear = IsLeapYear(CurYear); LeapYear = IsLeapYear(CurYear);
if (Days < YearLengths[LeapYear]) if (Days < YearLengths[LeapYear])
@ -290,15 +290,17 @@ RtlTimeToTimeFields(IN PLARGE_INTEGER Time,
CurYear++; CurYear++;
Days = Days - YearLengths[LeapYear]; Days = Days - YearLengths[LeapYear];
} }
TimeFields->Year = (CSHORT) CurYear; TimeFields->Year = (CSHORT)CurYear;
/* Compute month of year */ /* Compute month of year */
LeapYear = IsLeapYear(CurYear); LeapYear = IsLeapYear(CurYear);
Months = MonthLengths[LeapYear]; Months = MonthLengths[LeapYear];
for (CurMonth = 0; Days >= Months[CurMonth]; CurMonth++) for (CurMonth = 0; Days >= Months[CurMonth]; CurMonth++)
{
Days = Days - Months[CurMonth]; Days = Days - Months[CurMonth];
TimeFields->Month = (CSHORT) (CurMonth + 1); }
TimeFields->Day = (CSHORT) (Days + 1); TimeFields->Month = (CSHORT)(CurMonth + 1);
TimeFields->Day = (CSHORT)(Days + 1);
} }
@ -359,7 +361,7 @@ RtlLocalTimeToSystemTime(IN PLARGE_INTEGER LocalTime,
Status = ZwQuerySystemInformation(SystemTimeOfDayInformation, Status = ZwQuerySystemInformation(SystemTimeOfDayInformation,
&TimeInformation, &TimeInformation,
sizeof(SYSTEM_TIMEOFDAY_INFORMATION), sizeof(TimeInformation),
NULL); NULL);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
return Status; return Status;
@ -384,7 +386,7 @@ RtlSystemTimeToLocalTime(IN PLARGE_INTEGER SystemTime,
Status = ZwQuerySystemInformation(SystemTimeOfDayInformation, Status = ZwQuerySystemInformation(SystemTimeOfDayInformation,
&TimeInformation, &TimeInformation,
sizeof(SYSTEM_TIMEOFDAY_INFORMATION), sizeof(TimeInformation),
NULL); NULL);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
return Status; return Status;