Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-28 17:01:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NETID] Simplify IsUserAdmin() helper implementation (#5763)

Browse source 
Addendum to commit 8c4b0c914.

Base ourselves on pSetupIsUserAdmin() and other similar functions in our
codebase. Note that what we are actually interested here, is whether the
current thread runs with Administrator privileges.

(As noticed by contributor 'whindsaks', "Not only is this code simpler,
it now will correctly handle deny-only SIDs in the token!")
This commit is contained in:
Hermès Bélusca-Maïto 2023-10-06 14:45:52 +02:00
parent e685b25e35
commit d0b43a399f
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
1 changed files with 10 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
dll/win32/netid/netid.c
View file

@ -162,58 +162,22 @@ GetComputerNames(
static BOOL
IsUserAdmin(VOID)
{
BOOL bIsAdmin;
SID_IDENTIFIER_AUTHORITY Authority = {SECURITY_NT_AUTHORITY};
PSID pAdminsSid = NULL;
HANDLE hToken = NULL;
PTOKEN_GROUPS pGroups = NULL;
BOOL bIsAdmin = FALSE;
DWORD dwSize, i;
PSID pAdminsSid;
if (!AllocateAndInitializeSid(&Authority, 2, SECURITY_BUILTIN_DOMAIN_RID,
DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0,
if (!AllocateAndInitializeSid(&Authority, 2,
SECURITY_BUILTIN_DOMAIN_RID,
DOMAIN_ALIAS_RID_ADMINS,
0, 0, 0, 0, 0, 0,
&pAdminsSid))
{
return FALSE;
if (!OpenProcessToken(GetCurrentProcess(),
TOKEN_QUERY,
&hToken))
goto done;
if (GetTokenInformation(hToken, TokenGroups, NULL, 0, &dwSize) ||
GetLastError() != ERROR_INSUFFICIENT_BUFFER)
{
goto done;
}
pGroups = HeapAlloc(GetProcessHeap(), 0, dwSize);
if (pGroups == NULL)
goto done;
if (!GetTokenInformation(hToken,
TokenGroups,
pGroups,
dwSize,
&dwSize))
goto done;
for (i = 0; i < pGroups->GroupCount; i++)
{
if (EqualSid(pGroups->Groups[i].Sid, pAdminsSid))
{
bIsAdmin = TRUE;
break;
}
}
done:
if (pGroups != NULL)
HeapFree(GetProcessHeap(), 0, pGroups);
if (hToken != NULL)
CloseHandle(hToken);
if (pAdminsSid != NULL)
FreeSid(pAdminsSid);
if (!CheckTokenMembership(NULL, pAdminsSid, &bIsAdmin))
bIsAdmin = FALSE;
FreeSid(pAdminsSid);
return bIsAdmin;
}