From cf7f39eaba51997b557d2185c855675f00b53549 Mon Sep 17 00:00:00 2001 From: Johannes Anderwald Date: Sat, 19 Dec 2009 21:44:39 +0000 Subject: [PATCH] [MMIXER] - Fix buffer overflow svn path=/trunk/; revision=44660 --- reactos/lib/drivers/sound/mmixer/controls.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/reactos/lib/drivers/sound/mmixer/controls.c b/reactos/lib/drivers/sound/mmixer/controls.c index a366067ac21..adc8187b93e 100644 --- a/reactos/lib/drivers/sound/mmixer/controls.c +++ b/reactos/lib/drivers/sound/mmixer/controls.c @@ -576,8 +576,12 @@ MMixerCreateDestinationLine( if (LineName) { - wcscpy(DestinationLine->Line.szShortName, LineName); - wcscpy(DestinationLine->Line.szName, LineName); + MixerContext->Copy(DestinationLine->Line.szShortName, LineName, (min(MIXER_SHORT_NAME_CHARS, wcslen(LineName)+1)) * sizeof(WCHAR)); + DestinationLine->Line.szShortName[MIXER_SHORT_NAME_CHARS-1] = L'\0'; + + MixerContext->Copy(DestinationLine->Line.szName, LineName, (min(MIXER_LONG_NAME_CHARS, wcslen(LineName)+1)) * sizeof(WCHAR)); + DestinationLine->Line.szName[MIXER_LONG_NAME_CHARS-1] = L'\0'; + } else {