Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-02 15:46:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[LSASRV] Fix usage of self-relative security descriptor in LsarQuerySecurityObject

Browse source
This commit is contained in:
Timo Kreuzer 2023-09-23 17:43:14 +03:00
parent 5127433416
commit cf4aa7ea9d
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
dll/win32/lsasrv/lsarpc.c
View file

@ -201,7 +201,7 @@ LsarQuerySecurityObject(
PLSAPR_SR_SECURITY_DESCRIPTOR *SecurityDescriptor) PLSAPR_SR_SECURITY_DESCRIPTOR *SecurityDescriptor)
{ {
PLSA_DB_OBJECT DbObject = NULL; PLSA_DB_OBJECT DbObject = NULL;
PSECURITY_DESCRIPTOR RelativeSd = NULL; PISECURITY_DESCRIPTOR_RELATIVE RelativeSd = NULL;
PSECURITY_DESCRIPTOR ResultSd = NULL; PSECURITY_DESCRIPTOR ResultSd = NULL;
PLSAPR_SR_SECURITY_DESCRIPTOR SdData = NULL; PLSAPR_SR_SECURITY_DESCRIPTOR SdData = NULL;
ACCESS_MASK DesiredAccess = 0; ACCESS_MASK DesiredAccess = 0;
@ -256,16 +256,16 @@ LsarQuerySecurityObject(
/* Invalidate the SD information that was not requested */ /* Invalidate the SD information that was not requested */
if (!(SecurityInformation & OWNER_SECURITY_INFORMATION)) if (!(SecurityInformation & OWNER_SECURITY_INFORMATION))
((PISECURITY_DESCRIPTOR)RelativeSd)->Owner = NULL; RelativeSd->Owner = 0;
if (!(SecurityInformation & GROUP_SECURITY_INFORMATION)) if (!(SecurityInformation & GROUP_SECURITY_INFORMATION))
((PISECURITY_DESCRIPTOR)RelativeSd)->Group = NULL; RelativeSd->Group = 0;
if (!(SecurityInformation & DACL_SECURITY_INFORMATION)) if (!(SecurityInformation & DACL_SECURITY_INFORMATION))
((PISECURITY_DESCRIPTOR)RelativeSd)->Control &= ~SE_DACL_PRESENT; RelativeSd->Control &= ~SE_DACL_PRESENT;
if (!(SecurityInformation & SACL_SECURITY_INFORMATION)) if (!(SecurityInformation & SACL_SECURITY_INFORMATION))
((PISECURITY_DESCRIPTOR)RelativeSd)->Control &= ~SE_SACL_PRESENT; RelativeSd->Control &= ~SE_SACL_PRESENT;
/* Calculate the required SD size */ /* Calculate the required SD size */
Status = RtlMakeSelfRelativeSD(RelativeSd, Status = RtlMakeSelfRelativeSD(RelativeSd,
@ -298,7 +298,7 @@ LsarQuerySecurityObject(
} }
/* Fill the SD data buffer and return it to the caller */ /* Fill the SD data buffer and return it to the caller */
SdData->Length = RelativeSdSize; SdData->Length = ResultSdSize;
SdData->SecurityDescriptor = (PBYTE)ResultSd; SdData->SecurityDescriptor = (PBYTE)ResultSd;
*SecurityDescriptor = SdData; *SecurityDescriptor = SdData;