[SYSSETUP] security.c: Remove 3 useless casts

And
* Make 1 cast more explicit.
* Fix 1 'SamSetInformationUser' copypasta in DPRINT1() text.
* Optimize 1 '.MaximumLength' assignment.
This commit is contained in:
Serge Gautherie 2020-11-12 01:22:46 +01:00 committed by Jérôme Gardou
parent 5c54fb9179
commit ca1814f2c9

View file

@ -100,7 +100,7 @@ SetAccountsDomainSid(
LsaClose(PolicyHandle); LsaClose(PolicyHandle);
DomainNameInfo.DomainName.Length = wcslen(DomainName) * sizeof(WCHAR); DomainNameInfo.DomainName.Length = wcslen(DomainName) * sizeof(WCHAR);
DomainNameInfo.DomainName.MaximumLength = (wcslen(DomainName) + 1) * sizeof(WCHAR); DomainNameInfo.DomainName.MaximumLength = DomainNameInfo.DomainName.Length + sizeof(WCHAR);
DomainNameInfo.DomainName.Buffer = (LPWSTR)DomainName; DomainNameInfo.DomainName.Buffer = (LPWSTR)DomainName;
Status = SamConnect(NULL, Status = SamConnect(NULL,
@ -117,7 +117,7 @@ SetAccountsDomainSid(
{ {
Status = SamSetInformationDomain(DomainHandle, Status = SamSetInformationDomain(DomainHandle,
DomainNameInformation, DomainNameInformation,
(PVOID)&DomainNameInfo); &DomainNameInfo);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
DPRINT1("SamSetInformationDomain failed (Status: 0x%08lx)\n", Status); DPRINT1("SamSetInformationDomain failed (Status: 0x%08lx)\n", Status);
@ -1186,7 +1186,7 @@ EnableAccount(
Status = SamQueryInformationUser(UserHandle, Status = SamQueryInformationUser(UserHandle,
UserControlInformation, UserControlInformation,
(PVOID)&ControlInfo); (PVOID*)&ControlInfo);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
DPRINT1("SamQueryInformationUser() failed (Status: 0x%08lx)\n", Status); DPRINT1("SamQueryInformationUser() failed (Status: 0x%08lx)\n", Status);
@ -1289,7 +1289,7 @@ SetNewAccountName(
Status = SamSetInformationUser(UserHandle, Status = SamSetInformationUser(UserHandle,
UserNameInformation, UserNameInformation,
(PVOID)&NameInfo); &NameInfo);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
DPRINT1("SamSetInformationUser() failed (Status: 0x%08lx)\n", Status); DPRINT1("SamSetInformationUser() failed (Status: 0x%08lx)\n", Status);
@ -1655,7 +1655,7 @@ SetAdministratorPassword(LPCWSTR Password)
Status = SamSetInformationUser(UserHandle, Status = SamSetInformationUser(UserHandle,
UserSetPasswordInformation, UserSetPasswordInformation,
(PVOID)&PasswordInfo); &PasswordInfo);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
DPRINT1("SamSetInformationUser() failed (Status %08lx)\n", Status); DPRINT1("SamSetInformationUser() failed (Status %08lx)\n", Status);
@ -1667,7 +1667,7 @@ SetAdministratorPassword(LPCWSTR Password)
(PVOID*)&AccountNameInfo); (PVOID*)&AccountNameInfo);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
DPRINT1("SamSetInformationUser() failed (Status %08lx)\n", Status); DPRINT1("SamQueryInformationUser() failed (Status 0x%08lx)\n", Status);
goto done; goto done;
} }