Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-24 03:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

Allocate enough memory for Value (problem was spotted by Pigglesworth)

Browse source 
This problem was revealed by r36797 (thanks to aicom, elhoir, Lone_Rifle and vicmarcal for the help with regression testing)

Fixes ipconfig, ping and other network apps crashing with a buffer overflow.

svn path=/trunk/; revision=36816
This commit is contained in:
Colin Finck 2008-10-18 22:22:09 +00:00
parent eb2c5f864c
commit c9a04929cc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reactos/dll/win32/iphlpapi/registry.c
View file

@ -50,7 +50,7 @@ PWCHAR GetNthChildKeyName( HANDLE RegHandle, DWORD n ) {
} }
ValueLen = MaxAdapterName; ValueLen = MaxAdapterName;
Value = (PWCHAR)HeapAlloc( GetProcessHeap(), 0, MaxAdapterName ); Value = (PWCHAR)HeapAlloc( GetProcessHeap(), 0, MaxAdapterName * sizeof(WCHAR) );
Status = RegEnumKeyExW( RegHandle, n, Value, &ValueLen, Status = RegEnumKeyExW( RegHandle, n, Value, &ValueLen,
NULL, NULL, NULL, NULL ); NULL, NULL, NULL, NULL );
if (Status != ERROR_SUCCESS) if (Status != ERROR_SUCCESS)