Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-07 18:56:48 +00:00
Code Issues Projects Releases Packages Wiki Activity

[RAPPS] Fix item icons (#5896)

Browse source 
Based on KRosUser's rapps_v2.patch.
ExtractIconW can return (HICON)1.
We check this invalid value.
CORE-19317
This commit is contained in:
Katayama Hirofumi MZ 2023-11-08 19:53:02 +09:00 committed by GitHub
parent 97bf53eeb8
commit c6c7fc1182
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
base/applications/rapps/appview.cpp
View file

@ -1299,7 +1299,8 @@ CAppsListView::AddApplication(CAppInfo *AppInfo, BOOL InitialCheckState)
hIcon = ExtractIconW(hInst, szIconPath.GetString(), 0); hIcon = ExtractIconW(hInst, szIconPath.GetString(), 0);
} }
if (!hIcon) /* Use the default icon if none were found in the file, or if it is not supported (returned 1) */
if (!hIcon || (hIcon == (HICON)1))
{ {
/* Load default icon */ /* Load default icon */
hIcon = LoadIconW(hInst, MAKEINTRESOURCEW(IDI_MAIN)); hIcon = LoadIconW(hInst, MAKEINTRESOURCEW(IDI_MAIN));