Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-08 11:13:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WINESYNC] msi: Fix use after free error in TransformView_set_row.

Browse source 
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 6a0a0d2a0b15bffa9d4a5b41e75be6765e731d69 by Piotr Caban <piotr@codeweavers.com>
This commit is contained in:
winesync 2022-03-13 19:08:44 +01:00 • committed by Mark Jansen
parent 61167e123f
commit c6c4bdb242
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
dll/win32/msi/table.c
View file

@ -2341,7 +2341,7 @@ static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT
L"INSERT INTO `_TransformView` (`Table`, `Column`, `Row`, `Data`, `Current`) VALUES ('"; L"INSERT INTO `_TransformView` (`Table`, `Column`, `Row`, `Data`, `Current`) VALUES ('";
MSITABLEVIEW *tv = (MSITABLEVIEW*)view; MSITABLEVIEW *tv = (MSITABLEVIEW*)view;
WCHAR buf[256], *query = buf; WCHAR buf[256], *query;
MSIRECORD *old_rec; MSIRECORD *old_rec;
MSIQUERY *q; MSIQUERY *q;
WCHAR *key; WCHAR *key;
@ -2409,6 +2409,10 @@ static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT
return ERROR_OUTOFMEMORY; return ERROR_OUTOFMEMORY;
} }
} }
else
{
query = buf;
}
memcpy( query, query_pfx, p * sizeof(WCHAR) ); memcpy( query, query_pfx, p * sizeof(WCHAR) );
len = wcslen( tv->name ); len = wcslen( tv->name );