Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-22 16:36:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SERVICES] Enable the backup and restore privileges before loading or unloading a user profile and then disable them again.

Browse source
This commit is contained in:
Eric Kohl 2019-08-05 20:18:17 +02:00
parent 4414f45cc0
commit c6a53810a4
2 changed files with 62 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

63
base/system/services/database.c
View file

@ -279,18 +279,65 @@ ScmIsLocalSystemAccount(
} }
static
BOOL
ScmEnableBackupRestorePrivileges(
_In_ HANDLE hToken,
_In_ BOOL bEnable)
{
PTOKEN_PRIVILEGES pTokenPrivileges = NULL;
DWORD dwSize;
BOOL bRet = FALSE;
DPRINT("ScmEnableBackupRestorePrivileges(%p %d)\n", hToken, bEnable);
dwSize = sizeof(TOKEN_PRIVILEGES) + 2 * sizeof(LUID_AND_ATTRIBUTES);
pTokenPrivileges = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, dwSize);
if (pTokenPrivileges == NULL)
{
DPRINT1("Failed to allocate the privilege buffer!\n");
goto done;
}
pTokenPrivileges->PrivilegeCount = 2;
pTokenPrivileges->Privileges[0].Luid.LowPart = SE_BACKUP_PRIVILEGE;
pTokenPrivileges->Privileges[0].Luid.HighPart = 0;
pTokenPrivileges->Privileges[0].Attributes = (bEnable ? SE_PRIVILEGE_ENABLED : 0);
pTokenPrivileges->Privileges[1].Luid.LowPart = SE_RESTORE_PRIVILEGE;
pTokenPrivileges->Privileges[1].Luid.HighPart = 0;
pTokenPrivileges->Privileges[1].Attributes = (bEnable ? SE_PRIVILEGE_ENABLED : 0);
bRet = AdjustTokenPrivileges(hToken, FALSE, pTokenPrivileges, 0, NULL, NULL);
if (!bRet)
{
DPRINT1("AdjustTokenPrivileges() failed with error %lu\n", GetLastError());
}
else if (GetLastError() == ERROR_NOT_ALL_ASSIGNED)
{
DPRINT1("AdjustTokenPrivileges() succeeded, but with not all privileges assigned\n");
bRet = FALSE;
}
done:
if (pTokenPrivileges != NULL)
HeapFree(GetProcessHeap(), 0, pTokenPrivileges);
return bRet;
}
static static
DWORD DWORD
ScmLogonService( ScmLogonService(
IN PSERVICE pService, IN PSERVICE pService,
IN PSERVICE_IMAGE pImage) IN PSERVICE_IMAGE pImage)
{ {
DWORD dwError = ERROR_SUCCESS;
PROFILEINFOW ProfileInfo; PROFILEINFOW ProfileInfo;
PWSTR pszUserName = NULL; PWSTR pszUserName = NULL;
PWSTR pszDomainName = NULL; PWSTR pszDomainName = NULL;
PWSTR pszPassword = NULL; PWSTR pszPassword = NULL;
PWSTR ptr; PWSTR ptr;
DWORD dwError = ERROR_SUCCESS;
DPRINT("ScmLogonService(%p %p)\n", pService, pImage); DPRINT("ScmLogonService(%p %p)\n", pService, pImage);
DPRINT("Service %S\n", pService->lpServiceName); DPRINT("Service %S\n", pService->lpServiceName);
@ -355,9 +402,13 @@ ScmLogonService(
// ProfileInfo.lpPolicyPath = NULL; // ProfileInfo.lpPolicyPath = NULL;
// ProfileInfo.hProfile = NULL; // ProfileInfo.hProfile = NULL;
ScmEnableBackupRestorePrivileges(pImage->hToken, TRUE);
if (!LoadUserProfileW(pImage->hToken, &ProfileInfo)) if (!LoadUserProfileW(pImage->hToken, &ProfileInfo))
{
dwError = GetLastError(); dwError = GetLastError();
ScmEnableBackupRestorePrivileges(pImage->hToken, FALSE);
if (dwError != ERROR_SUCCESS)
{
DPRINT1("LoadUserProfileW() failed (Error %lu)\n", dwError); DPRINT1("LoadUserProfileW() failed (Error %lu)\n", dwError);
goto done; goto done;
} }
@ -475,7 +526,11 @@ ScmCreateOrReferenceServiceImage(PSERVICE pService)
/* Unload the user profile */ /* Unload the user profile */
if (pServiceImage->hProfile != NULL) if (pServiceImage->hProfile != NULL)
{
ScmEnableBackupRestorePrivileges(pServiceImage->hToken, TRUE);
UnloadUserProfile(pServiceImage->hToken, pServiceImage->hProfile); UnloadUserProfile(pServiceImage->hToken, pServiceImage->hProfile);
ScmEnableBackupRestorePrivileges(pServiceImage->hToken, FALSE);
}
/* Close the logon token */ /* Close the logon token */
if (pServiceImage->hToken != NULL) if (pServiceImage->hToken != NULL)
@ -546,7 +601,11 @@ ScmRemoveServiceImage(PSERVICE_IMAGE pServiceImage)
/* Unload the user profile */ /* Unload the user profile */
if (pServiceImage->hProfile != NULL) if (pServiceImage->hProfile != NULL)
{
ScmEnableBackupRestorePrivileges(pServiceImage->hToken, TRUE);
UnloadUserProfile(pServiceImage->hToken, pServiceImage->hProfile); UnloadUserProfile(pServiceImage->hToken, pServiceImage->hProfile);
ScmEnableBackupRestorePrivileges(pServiceImage->hToken, FALSE);
}
/* Close the logon token */ /* Close the logon token */
if (pServiceImage->hToken != NULL) if (pServiceImage->hToken != NULL)

1
base/system/services/services.h
View file

@ -19,6 +19,7 @@
#include <winuser.h> #include <winuser.h>
#include <netevent.h> #include <netevent.h>
#define NTOS_MODE_USER #define NTOS_MODE_USER
#include <ndk/setypes.h>
#include <ndk/obfuncs.h> #include <ndk/obfuncs.h>
#include <ndk/rtlfuncs.h> #include <ndk/rtlfuncs.h>
#include <services/services.h> #include <services/services.h>