Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-17 16:27:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

[RTL]: Fix bugs in SD rewrite, bringing tests back to 73 failures instead of 117 (back to their normal).

Browse source 
svn path=/trunk/; revision=57458
This commit is contained in:
Alex Ionescu 2012-10-02 16:05:26 +00:00
parent 9a802e9079
commit c5f87ff647
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
reactos/lib/rtl/sd.c
View file

@ -147,6 +147,7 @@ RtlCreateSecurityDescriptorRelative(IN PISECURITY_DESCRIPTOR_RELATIVE SecurityDe
/* Setup an empty SD */ /* Setup an empty SD */
RtlZeroMemory(SecurityDescriptor, sizeof(*SecurityDescriptor)); RtlZeroMemory(SecurityDescriptor, sizeof(*SecurityDescriptor));
SecurityDescriptor->Revision = SECURITY_DESCRIPTOR_REVISION; SecurityDescriptor->Revision = SECURITY_DESCRIPTOR_REVISION;
SecurityDescriptor->Control = SE_SELF_RELATIVE;
/* All good */ /* All good */
return STATUS_SUCCESS; return STATUS_SUCCESS;
@ -560,14 +561,14 @@ RtlSetAttributesSecurityDescriptor(IN PSECURITY_DESCRIPTOR SecurityDescriptor,
if (Sd->Revision != SECURITY_DESCRIPTOR_REVISION) return STATUS_UNKNOWN_REVISION; if (Sd->Revision != SECURITY_DESCRIPTOR_REVISION) return STATUS_UNKNOWN_REVISION;
/* Mask out flags which are not attributes */ /* Mask out flags which are not attributes */
Control &= ~SE_DACL_UNTRUSTED | Control &= SE_DACL_UNTRUSTED |
SE_SERVER_SECURITY | SE_SERVER_SECURITY |
SE_DACL_AUTO_INHERIT_REQ | SE_DACL_AUTO_INHERIT_REQ |
SE_SACL_AUTO_INHERIT_REQ | SE_SACL_AUTO_INHERIT_REQ |
SE_DACL_AUTO_INHERITED | SE_DACL_AUTO_INHERITED |
SE_SACL_AUTO_INHERITED | SE_SACL_AUTO_INHERITED |
SE_DACL_PROTECTED | SE_DACL_PROTECTED |
SE_SACL_PROTECTED; SE_SACL_PROTECTED;
/* Call the newer API */ /* Call the newer API */
return RtlSetControlSecurityDescriptor(SecurityDescriptor, Control, Control); return RtlSetControlSecurityDescriptor(SecurityDescriptor, Control, Control);
@ -1153,7 +1154,7 @@ RtlValidRelativeSecurityDescriptor(IN PSECURITY_DESCRIPTOR SecurityDescriptorInp
} }
/* Read the group, check if it's valid and if the buffer contains it */ /* Read the group, check if it's valid and if the buffer contains it */
Group = (PSID)((ULONG_PTR)Sd->Owner + (ULONG_PTR)Sd); Group = (PSID)((ULONG_PTR)Sd->Group + (ULONG_PTR)Sd);
if (!RtlValidSid(Group) || (Length < RtlLengthSid(Group))) return FALSE; if (!RtlValidSid(Group) || (Length < RtlLengthSid(Group))) return FALSE;
} }
else if (RequiredInformation & GROUP_SECURITY_INFORMATION) else if (RequiredInformation & GROUP_SECURITY_INFORMATION)