Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-08-11 21:58:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

[SHELL32]

Browse source 
Avoid double-free and use-after-free in case the FSD fails to register the change directory notification

CORE-13549

svn path=/trunk/; revision=75348
This commit is contained in:
Pierre Schweitzer 2017-07-15 07:45:28 +00:00
parent 47ade62a62
commit c4689f7e1d
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
reactos/dll/win32/shell32/wine/changenotify.c
View file

@ -723,6 +723,20 @@ _NotificationCompletion(DWORD dwErrorCode, // completion code
}
#endif
#ifdef __REACTOS__
/* This is to avoid double-free and potential use after free
* In case it failed, _BeginRead() already deferenced item
* But if failure comes the FSD, the APC routine (us) will
* be called as well, which will cause a double-free on quit.
* Avoid this by deferencing only once in case of failure and thus,
* incrementing reference count here
*/
if (dwErrorCode != ERROR_SUCCESS)
{
InterlockedIncrement(&item->pParent->wQueuedCount);
}
#endif
/* This likely means overflow, so force whole directory refresh. */
if (!dwNumberOfBytesTransfered)
{