From c37fa08214bd8e16fb8e6374f337cfc0d8a587b5 Mon Sep 17 00:00:00 2001 From: Alex Ionescu Date: Sun, 2 Sep 2012 20:56:55 +0000 Subject: [PATCH] [NTOSKRNL]: Warn, but do not ASSERT, about the fact that we don't have commit charges yet. Fixes OllyDbg2 assertions (and probably others too). svn path=/trunk/; revision=57223 --- reactos/ntoskrnl/mm/ARM3/miarm.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/reactos/ntoskrnl/mm/ARM3/miarm.h b/reactos/ntoskrnl/mm/ARM3/miarm.h index a5cf5cbc246..3cdacfebac1 100644 --- a/reactos/ntoskrnl/mm/ARM3/miarm.h +++ b/reactos/ntoskrnl/mm/ARM3/miarm.h @@ -94,8 +94,8 @@ C_ASSERT(SYSTEM_PD_SIZE == PAGE_SIZE); #endif // -// Protection Bits part of the internal memory manager Protection Mask -// Taken from http://www.reactos.org/wiki/Techwiki:Memory_management_in_the_Windows_XP_kernel +// Protection Bits part of the internal memory manager Protection Mask, from: +// http://reactos.org/wiki/Techwiki:Memory_management_in_the_Windows_XP_kernel // and public assertions. // #define MM_ZERO_ACCESS 0 @@ -1263,8 +1263,8 @@ MiDropLockCount(IN PMMPFN Pfn1) if ((Pfn1->u3.e1.PrototypePte == 1) && (Pfn1->OriginalPte.u.Soft.Prototype == 1)) { - /* We don't handle this */ - ASSERT(FALSE); + /* FIXME: We should return commit */ + DPRINT1("Not returning commit for prototype PTE\n"); } /* Update the counter */ @@ -1301,8 +1301,8 @@ MiDereferencePfnAndDropLockCount(IN PMMPFN Pfn1) if ((Pfn1->u3.e1.PrototypePte == 1) && (Pfn1->OriginalPte.u.Soft.Prototype == 1)) { - /* We don't handle this */ - ASSERT(FALSE); + /* FIXME: We should return commit */ + DPRINT1("Not returning commit for prototype PTE\n"); } /* Update the counter, and drop a reference the long way */ @@ -1407,8 +1407,8 @@ MiReferenceUsedPageAndBumpLockCount(IN PMMPFN Pfn1) if ((Pfn1->u3.e1.PrototypePte == 1) && (Pfn1->OriginalPte.u.Soft.Prototype == 1)) { - /* We don't handle this */ - ASSERT(FALSE); + /* FIXME: We should charge commit */ + DPRINT1("Not charging commit for prototype PTE\n"); } /* More locked pages! */ @@ -1456,8 +1456,8 @@ MiReferenceUnusedPageAndBumpLockCount(IN PMMPFN Pfn1) if ((Pfn1->u3.e1.PrototypePte == 1) && (Pfn1->OriginalPte.u.Soft.Prototype == 1)) { - /* We don't handle this */ - ASSERT(FALSE); + /* FIXME: We should charge commit */ + DPRINT1("Not charging commit for prototype PTE\n"); } /* More locked pages! */