- Remove unnecessary allow_warnings throughout the code base
- Make -Wnarrowing an error unless excepted specifically (only done in explorer)

svn path=/trunk/; revision=62566
This commit is contained in:
Thomas Faber 2014-03-26 11:08:45 +00:00
parent 7872f6a066
commit c362a06522
18 changed files with 8 additions and 36 deletions

View file

@ -7,10 +7,4 @@ add_executable(atactl atactl.cpp atactl.rc)
set_module_type(atactl win32cui)
add_importlibs(atactl advapi32 msvcrt kernel32 ntdll)
if(NOT MSVC)
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
#allow_warnings(atactl)
set_source_files_properties(atactl.cpp PROPERTIES COMPILE_FLAGS "-Wno-error")
endif()
add_cd_file(TARGET atactl DESTINATION reactos/system32 FOR all)

View file

@ -3,9 +3,3 @@ add_executable(write write.c rsrc.rc)
set_module_type(write win32gui UNICODE)
add_importlibs(write user32 gdi32 msvcrt kernel32)
add_cd_file(TARGET write DESTINATION reactos/system32 FOR all)
if(NOT MSVC)
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
#allow_warnings(write)
set_source_files_properties(write.c PROPERTIES COMPILE_FLAGS "-Wno-error")
endif()

View file

@ -60,3 +60,7 @@ add_pch(explorer precomp.h SOURCE)
add_dependencies(explorer psdk)
add_cd_file(TARGET explorer DESTINATION reactos FOR all)
add_cd_file(FILE ${CMAKE_CURRENT_SOURCE_DIR}/explorer-cfg-template.xml DESTINATION reactos FOR all)
if(NOT MSVC)
add_compile_flags("-Wno-error=narrowing")
endif()

View file

@ -85,7 +85,6 @@ if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
add_compile_flags("-Wno-error=unused-but-set-variable")
endif()
add_compile_flags("-Wno-error=narrowing")
add_compile_flags("-Wtype-limits -Wno-error=type-limits")
if(ARCH STREQUAL "amd64")

View file

@ -49,5 +49,4 @@ add_cd_file(TARGET libxslt DESTINATION reactos/system32 FOR all)
if(NOT MSVC)
add_target_compile_flags(libxslt "-Wno-pointer-sign -Wno-unused-but-set-variable -Wno-unused-function")
allow_warnings(libxslt)
endif()

View file

@ -15,5 +15,5 @@ add_importlibs(mciseq winmm user32 msvcrt kernel32 ntdll)
add_cd_file(TARGET mciseq DESTINATION reactos/system32 FOR all)
if(NOT MSVC)
allow_warnings(mciseq)
add_target_compile_flags(mciseq "-Wno-error=overflow")
endif()

View file

@ -21,5 +21,5 @@ add_dependencies(mciwave psdk)
add_cd_file(TARGET mciwave DESTINATION reactos/system32 FOR all)
if(NOT MSVC)
allow_warnings(mciwave)
add_target_compile_flags(mciwave "-Wno-error=overflow")
endif()

View file

@ -12,10 +12,8 @@ list(APPEND SOURCE
add_library(fbtusb SHARED ${SOURCE} fbtusb.rc)
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
if(NOT MSVC)
#allow_warnings(fbtusb)
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error -Wno-unused-but-set-variable")
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-unused-but-set-variable")
endif()
set_module_type(fbtusb kernelmodedriver)

View file

@ -28,7 +28,6 @@ if(NOT MSVC)
add_compile_flags("-Wno-unused-but-set-variable")
endif()
allow_warnings(ext2fs)
target_link_libraries(ext2fs ${PSEH_LIB})
add_pch(ext2fs inc/ext2fsd.h SOURCE)
set_module_type(ext2fs kernelmodedriver)

View file

@ -22,9 +22,7 @@ add_library(uniata SHARED ${SOURCE} idedma.rc)
if(NOT MSVC)
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
#allow_warnings(uniata)
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error -Wno-unused-but-set-variable -Wno-narrowing")
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-unused-but-set-variable -Wno-narrowing")
endif()
add_pch(uniata stdafx.h SOURCE)

View file

@ -17,7 +17,6 @@ list(APPEND SOURCE
ff_time.c)
add_library(fullfat ${SOURCE})
allow_warnings(fullfat)
add_dependencies(fullfat bugcodes)
if(NOT MSVC)

View file

@ -44,4 +44,3 @@ list(APPEND SOURCE
add_library(libmpg123 ${SOURCE})
add_dependencies(libmpg123 psdk)
add_pch(libmpg123 precomp.h SOURCE)
allow_warnings(libmpg123)

View file

@ -61,7 +61,6 @@ add_library(lwip ${SOURCE})
add_dependencies(lwip bugcodes)
add_pch(lwip precomp.h SOURCE)
if(NOT MSVC)
allow_warnings(lwip)
if(LTCG)
add_compile_flags("-fno-builtin-malloc -fno-builtin-free")
endif()

View file

@ -14,4 +14,3 @@ list(APPEND SOURCE
add_library(ext2lib ${SOURCE})
add_pch(ext2lib Mke2fs.h SOURCE)
add_dependencies(ext2lib psdk)
allow_warnings(ext2lib)

View file

@ -20,7 +20,6 @@ if(NOT MSVC)
endif()
add_library(pseh ${SOURCE})
allow_warnings(pseh)
target_link_libraries(pseh chkstk)
add_dependencies(pseh psdk)

View file

@ -19,4 +19,3 @@ list(APPEND SOURCE
add_library(rossym ${SOURCE})
add_pch(rossym precomp.h)
add_dependencies(rossym psdk bugcodes)
allow_warnings(rossym)

View file

@ -83,7 +83,6 @@ set_source_files_properties(startup/crtexe.c
if(NOT MSVC)
target_link_libraries(msvcrtex oldnames)
allow_warnings(msvcrtex)
endif()
add_dependencies(msvcrtex psdk asm)

View file

@ -13,12 +13,6 @@ add_library(vga SHARED
target_link_libraries(vga libcntpr)
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
if(NOT MSVC)
#allow_warnings(vga)
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error")
endif()
set_module_type(vga kernelmodedriver)
add_importlibs(vga videoprt)