[PCIIDEX] Improve and fix the driver

- Fix IRP handling, add missing IRP handlers
- Specify the device name for DO
- The legacy IRQ descriptor is edge-triggered
- Improve pool tagging
- Place the PNP code in a pageable section

CORE-17256

drivers/storage/ide/pciidex/pciidex.h

@@ -1,74 +1,146 @@
+/*
+ * PROJECT:     PCI IDE bus driver extension
+ * LICENSE:     See COPYING in the top level directory
+ * PURPOSE:     Common header file
+ * COPYRIGHT:   Copyright 2005 Hervé Poussineau <hpoussin@reactos.org>
+ *              Copyright 2023 Dmitry Borisov <di.sean@protonmail.com>
+ */
+
 #ifndef _PCIIDEX_PCH_
 #define _PCIIDEX_PCH_
 
-#include <ntifs.h>
+#include <ntddk.h>
+#include <ntstrsafe.h>
+#include <ntintsafe.h>
+#include <initguid.h>
+#include <wdmguid.h>
 #include <ide.h>
 
+#define TAG_PCIIDEX    'XedI'
+
+#define IS_FDO(p)    (((PCOMMON_DEVICE_EXTENSION)(p))->IsFDO)
+
+#define IS_PRIMARY_CHANNEL(PdoExtension)    (PdoExtension->Channel == 0)
+
+/*
+ * Legacy ranges and interrupts
+ */
+#define PCIIDE_LEGACY_RESOURCE_COUNT                3
+#define PCIIDE_LEGACY_COMMAND_IO_RANGE_LENGTH       8
+#define PCIIDE_LEGACY_CONTROL_IO_RANGE_LENGTH       1
+#define PCIIDE_LEGACY_PRIMARY_COMMAND_BASE      0x1F0
+#define PCIIDE_LEGACY_PRIMARY_CONTROL_BASE      0x3F6
+#define PCIIDE_LEGACY_PRIMARY_IRQ                  14
+#define PCIIDE_LEGACY_SECONDARY_COMMAND_BASE    0x170
+#define PCIIDE_LEGACY_SECONDARY_CONTROL_BASE    0x376
+#define PCIIDE_LEGACY_SECONDARY_IRQ                15
+
+/*
+ * Programming Interface Register
+ */
+#define PCIIDE_PROGIF_PRIMARY_CHANNEL_NATIVE_MODE              0x01
+#define PCIIDE_PROGIF_PRIMARY_CHANNEL_NATIVE_MODE_CAPABLE      0x02
+#define PCIIDE_PROGIF_SECONDARY_CHANNEL_NATIVE_MODE            0x04
+#define PCIIDE_PROGIF_SECONDARY_CHANNEL_NATIVE_MODE_CAPABLE    0x08
+#define PCIIDE_PROGIF_DMA_CAPABLE                              0x80
+
+#define BM_SECONDARY_CHANNEL_OFFSET      8
+
+typedef struct _PDO_DEVICE_EXTENSION    PDO_DEVICE_EXTENSION, *PPDO_DEVICE_EXTENSION;
+
 typedef struct _PCIIDEX_DRIVER_EXTENSION
 {
-	PCONTROLLER_PROPERTIES HwGetControllerProperties;
-	ULONG MiniControllerExtensionSize;
-	PCIIDE_UDMA_MODES_SUPPORTED HwUdmaModesSupported;
+    PCONTROLLER_PROPERTIES HwGetControllerProperties;
+    ULONG MiniControllerExtensionSize;
 } PCIIDEX_DRIVER_EXTENSION, *PPCIIDEX_DRIVER_EXTENSION;
 
 typedef struct _COMMON_DEVICE_EXTENSION
 {
-	BOOLEAN IsFDO;
+    BOOLEAN IsFDO;
+    PDEVICE_OBJECT Self;
+
+    _Write_guarded_by_(_Global_interlock_)
+    volatile LONG PageFiles;
+
+    _Write_guarded_by_(_Global_interlock_)
+    volatile LONG HibernateFiles;
+
+    _Write_guarded_by_(_Global_interlock_)
+    volatile LONG DumpFiles;
 } COMMON_DEVICE_EXTENSION, *PCOMMON_DEVICE_EXTENSION;
 
 typedef struct _FDO_DEVICE_EXTENSION
 {
-	COMMON_DEVICE_EXTENSION Common;
+    COMMON_DEVICE_EXTENSION Common;
+    PDEVICE_OBJECT Ldo;
 
-	PBUS_INTERFACE_STANDARD BusInterface;
-	IDE_CONTROLLER_PROPERTIES Properties;
-	PHYSICAL_ADDRESS BusMasterPortBase;
-	PDEVICE_OBJECT LowerDevice;
-	PDEVICE_OBJECT Pdo[MAX_IDE_CHANNEL];
-	USHORT VendorId;
-	USHORT DeviceId;
-	PUCHAR MiniControllerExtension[0];
+    ULONG ControllerNumber;
+    BOOLEAN InNativeMode;
+    BOOLEAN IoBaseMapped;
+    BOOLEAN MiniportStarted;
+
+    FAST_MUTEX DeviceSyncMutex;
+    _Guarded_by_(DeviceSyncMutex)
+    PPDO_DEVICE_EXTENSION Channels[MAX_IDE_CHANNEL];
+
+    USHORT VendorId;
+    USHORT DeviceId;
+    PDRIVER_OBJECT DriverObject;
+    PUCHAR BusMasterPortBase;
+
+    KSPIN_LOCK BusDataLock;
+    BUS_INTERFACE_STANDARD BusInterface;
+
+    IDE_CONTROLLER_PROPERTIES Properties;
+
+    /* Must be the last entry */
+    PUCHAR MiniControllerExtension[0];
 } FDO_DEVICE_EXTENSION, *PFDO_DEVICE_EXTENSION;
 
 typedef struct _PDO_DEVICE_EXTENSION
 {
-	COMMON_DEVICE_EXTENSION Common;
-
-	ULONG Channel;
-	PDEVICE_OBJECT ControllerFdo;
+    COMMON_DEVICE_EXTENSION Common;
+    ULONG Channel;
+    PFDO_DEVICE_EXTENSION ParentController;
+    BOOLEAN ReportedMissing;
+    PUCHAR IoBase;
 } PDO_DEVICE_EXTENSION, *PPDO_DEVICE_EXTENSION;
 
-/* fdo.c */
+CODE_SEG("PAGE")
+DRIVER_INITIALIZE DriverEntry;
 
+CODE_SEG("PAGE")
+DRIVER_UNLOAD PciIdeXUnload;
+
+CODE_SEG("PAGE")
 DRIVER_ADD_DEVICE PciIdeXAddDevice;
-NTSTATUS NTAPI
-PciIdeXAddDevice(
-	IN PDRIVER_OBJECT DriverObject,
-	IN PDEVICE_OBJECT Pdo);
 
-NTSTATUS NTAPI
-PciIdeXFdoPnpDispatch(
-	IN PDEVICE_OBJECT DeviceObject,
-	IN PIRP Irp);
+_Dispatch_type_(IRP_MJ_PNP)
+CODE_SEG("PAGE")
+DRIVER_DISPATCH_PAGED PciIdeXDispatchPnp;
 
-/* misc.c */
+_Dispatch_type_(IRP_MJ_SYSTEM_CONTROL)
+CODE_SEG("PAGE")
+DRIVER_DISPATCH_PAGED PciIdeXDispatchWmi;
 
-NTSTATUS NTAPI
-ForwardIrpAndForget(
-	IN PDEVICE_OBJECT DeviceObject,
-	IN PIRP Irp);
+_Dispatch_type_(IRP_MJ_POWER)
+DRIVER_DISPATCH_RAISED PciIdeXDispatchPower;
 
+CODE_SEG("PAGE")
 NTSTATUS
-DuplicateUnicodeString(
-	IN ULONG Flags,
-	IN PCUNICODE_STRING SourceString,
-	OUT PUNICODE_STRING DestinationString);
+PciIdeXFdoDispatchPnp(
+    _In_ PFDO_DEVICE_EXTENSION FdoExtension,
+    _Inout_ PIRP Irp);
 
-/* pdo.c */
+CODE_SEG("PAGE")
+NTSTATUS
+PciIdeXStartMiniport(
+    _In_ PFDO_DEVICE_EXTENSION FdoExtension);
 
-NTSTATUS NTAPI
-PciIdeXPdoPnpDispatch(
-	IN PDEVICE_OBJECT DeviceObject,
-	IN PIRP Irp);
+CODE_SEG("PAGE")
+IDE_CHANNEL_STATE
+PciIdeXChannelState(
+    _In_ PFDO_DEVICE_EXTENSION FdoExtension,
+    _In_ ULONG Channel);
 
 #endif /* _PCIIDEX_PCH_ */