Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-07-03 19:24:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[KDGDB]

Browse source 
- Add a ugly and grotesque hack to give "o" back to RtlAssert so that we actually break on ASSERTs
 - Check for the breakpoint instruction for deciding when to move forward the ProgramCounter. This is OK since KD removes all breakpoints set when hitting a soft BP


svn path=/trunk/; revision=72467
This commit is contained in:
Jérôme Gardou 2016-08-26 21:07:27 +00:00
parent 2e18c7a3cf
commit c0b63bd391
3 changed files with 22 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reactos/drivers/base/kdgdb/gdb_input.c
View file

@ -830,7 +830,7 @@ handle_gdb_c(
/* See if we should update the program counter */
if (Exception && (Exception->ExceptionRecord.ExceptionCode == STATUS_BREAKPOINT)
&& ProgramCounter == KdDebuggerDataBlock->BreakpointWithStatus.Pointer)
&& ((*(KD_BREAKPOINT_TYPE*)ProgramCounter) == KD_BREAKPOINT_VALUE))
{
/* We must get past the breakpoint instruction */
KdpSetContextPc(&CurrentContext, ProgramCounter + KD_BREAKPOINT_SIZE);

2
reactos/drivers/base/kdgdb/kdgdb.h
View file

@ -121,7 +121,9 @@ extern void gdb_send_registers(void);
((Context)->Eip)
# define KdpSetContextPc(Context, ProgramCounter) \
((Context)->Eip = (ProgramCounter))
# define KD_BREAKPOINT_TYPE UCHAR
# define KD_BREAKPOINT_SIZE sizeof(UCHAR)
# define KD_BREAKPOINT_VALUE 0xCC
/* Single step mode */
# define KdpSetSingleStep(Context) \
((Context)->EFlags |= EFLAGS_TF)

31
reactos/drivers/base/kdgdb/kdpacket.c
View file

@ -183,6 +183,7 @@ send_kd_debug_io(
switch (DebugIO->ApiNumber)
{
case DbgKdPrintStringApi:
case DbgKdGetStringApi:
gdb_send_debug_io(String, TRUE);
break;
default:
@ -362,28 +363,34 @@ KdReceivePacket(
_Out_ PULONG DataLength,
_Inout_ PKD_CONTEXT KdContext)
{
DBGKD_MANIPULATE_STATE64* State;
/* Special handling for breakin packet */
if (PacketType == PACKET_TYPE_KD_POLL_BREAKIN)
{
return KdpPollBreakIn();
}
if (PacketType != PACKET_TYPE_KD_STATE_MANIPULATE)
if (PacketType == PACKET_TYPE_KD_DEBUG_IO)
{
/* What should we do ? */
while (1);
/* HACK ! RtlAssert asks for (boipt), always say "o" --> break once. */
MessageData->Length = 1;
MessageData->Buffer[0] = 'o';
return KdPacketReceived;
}
State = (DBGKD_MANIPULATE_STATE64*)MessageHeader->Buffer;
if (PacketType == PACKET_TYPE_KD_STATE_MANIPULATE)
{
DBGKD_MANIPULATE_STATE64* State = (DBGKD_MANIPULATE_STATE64*)MessageHeader->Buffer;
/* Maybe we are in a send<->receive loop that GDB doesn't need to know about */
if (KdpManipulateStateHandler != NULL)
return KdpManipulateStateHandler(State, MessageData, DataLength, KdContext);
/* Maybe we are in a send<->receive loop that GDB doesn't need to know about */
if (KdpManipulateStateHandler != NULL)
return KdpManipulateStateHandler(State, MessageData, DataLength, KdContext);
/* Receive data from GDB and interpret it */
return gdb_receive_and_interpret_packet(State, MessageData, DataLength, KdContext);
/* Receive data from GDB and interpret it */
return gdb_receive_and_interpret_packet(State, MessageData, DataLength, KdContext);
}
/* What should we do ? */
while (1);
return KdPacketNeedsResend;
}
VOID