Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 20:56:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

[0.4.9][WIN32SS] Improve many apps not starting with active taskbar pane (#2396)

Browse source 
Many thanks to the patches author JIRA-user "blueghost"
tibor.fuzi@gmail.com

The patch fixes regression CORE-16703, which was unhidden by explorer commit
8ad0eae687 == SVN r74968
although the root-cause was missing functionality in WIN32SS.

The patch also fixes CORE-16705 and CORE-16706.
fix picked from 0.4.14-dev-1137-g 848d7ec633
----------
And while touching winpos.c I decided to also port back the
fix for the format-string-glitch from #1893 authored by Stanislav Motylkov.
fix picked from 0.4.13-dev-1079-g b16ca9cd65
This commit is contained in:
Joachim Henze 2020-12-19 20:50:12 +01:00
parent 959f2dd103
commit c0995eebd5
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
win32ss/user/ntuser/focus.c
View file

@ -52,7 +52,6 @@ VOID FASTCALL
UpdateShellHook(PWND Window) UpdateShellHook(PWND Window)
{ {
if ( Window->spwndParent == UserGetDesktopWindow() && if ( Window->spwndParent == UserGetDesktopWindow() &&
Window->spwndOwner == NULL &&
(!(Window->ExStyle & WS_EX_TOOLWINDOW) || (!(Window->ExStyle & WS_EX_TOOLWINDOW) ||
(Window->ExStyle & WS_EX_APPWINDOW))) (Window->ExStyle & WS_EX_APPWINDOW)))
{ {
@ -511,6 +510,7 @@ co_IntSendActivateMessages(PWND WindowPrev, PWND Window, BOOL MouseActivate, BOO
MAKEWPARAM(MouseActivate ? WA_CLICKACTIVE : WA_ACTIVE, (Window->style & WS_MINIMIZE) != 0), MAKEWPARAM(MouseActivate ? WA_CLICKACTIVE : WA_ACTIVE, (Window->style & WS_MINIMIZE) != 0),
(LPARAM)(WindowPrev ? UserHMGetHandle(WindowPrev) : 0)); (LPARAM)(WindowPrev ? UserHMGetHandle(WindowPrev) : 0));
if (Window->style & WS_VISIBLE)
UpdateShellHook(Window); UpdateShellHook(Window);
Window->state &= ~WNDS_NONCPAINT; Window->state &= ~WNDS_NONCPAINT;

6
win32ss/user/ntuser/winpos.c
View file

@ -1694,7 +1694,7 @@ co_WinPosSetWindowPos(
ASSERT_REFS_CO(Window); ASSERT_REFS_CO(Window);
TRACE("pwnd %p, after %p, %d,%d (%dx%d), flags %s", TRACE("pwnd %p, after %p, %d,%d (%dx%d), flags 0x%x",
Window, WndInsertAfter, x, y, cx, cy, flags); Window, WndInsertAfter, x, y, cx, cy, flags);
#if DBG #if DBG
dump_winpos_flags(flags); dump_winpos_flags(flags);
@ -1856,7 +1856,11 @@ co_WinPosSetWindowPos(
Window->spwndOwner == NULL && Window->spwndOwner == NULL &&
(!(Window->ExStyle & WS_EX_TOOLWINDOW) || (!(Window->ExStyle & WS_EX_TOOLWINDOW) ||
(Window->ExStyle & WS_EX_APPWINDOW))) (Window->ExStyle & WS_EX_APPWINDOW)))
{
co_IntShellHookNotify(HSHELL_WINDOWCREATED, (WPARAM)Window->head.h, 0); co_IntShellHookNotify(HSHELL_WINDOWCREATED, (WPARAM)Window->head.h, 0);
if (!(WinPos.flags & SWP_NOACTIVATE))
UpdateShellHook(Window);
}
Window->style |= WS_VISIBLE; //IntSetStyle( Window, WS_VISIBLE, 0 ); Window->style |= WS_VISIBLE; //IntSetStyle( Window, WS_VISIBLE, 0 );
Window->head.pti->cVisWindows++; Window->head.pti->cVisWindows++;