Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 20:23:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

[CMLIB] Adjust parameter types and annotations. Add diagnostic assertions.

Browse source
This commit is contained in:
Hermès Bélusca-Maïto 2018-10-14 00:16:04 +02:00
parent 801b71b9bf
commit bf8a7d2db0
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
3 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
sdk/lib/cmlib/cmlib.h
View file

@ -595,7 +595,7 @@ CmpFindNameInList(
IN PHHIVE Hive, IN PHHIVE Hive,
IN PCHILD_LIST ChildList, IN PCHILD_LIST ChildList,
IN PUNICODE_STRING Name, IN PUNICODE_STRING Name,
OUT PULONG ChildIndex, OUT PULONG ChildIndex OPTIONAL,
OUT PHCELL_INDEX CellIndex OUT PHCELL_INDEX CellIndex
); );
@ -625,7 +625,7 @@ CmpSetValueDataNew(
IN PHHIVE Hive, IN PHHIVE Hive,
IN PVOID Data, IN PVOID Data,
IN ULONG DataSize, IN ULONG DataSize,
IN ULONG StorageType, IN HSTORAGE_TYPE StorageType,
IN HCELL_INDEX ValueCell, IN HCELL_INDEX ValueCell,
OUT PHCELL_INDEX DataCell OUT PHCELL_INDEX DataCell
); );
@ -636,7 +636,7 @@ CmpAddValueToList(
IN PHHIVE Hive, IN PHHIVE Hive,
IN HCELL_INDEX ValueCell, IN HCELL_INDEX ValueCell,
IN ULONG Index, IN ULONG Index,
IN ULONG Type, IN HSTORAGE_TYPE StorageType,
IN OUT PCHILD_LIST ChildList IN OUT PCHILD_LIST ChildList
); );

2
sdk/lib/cmlib/cmname.c
View file

@ -149,7 +149,7 @@ NTAPI
CmpFindNameInList(IN PHHIVE Hive, CmpFindNameInList(IN PHHIVE Hive,
IN PCHILD_LIST ChildList, IN PCHILD_LIST ChildList,
IN PUNICODE_STRING Name, IN PUNICODE_STRING Name,
OUT PULONG ChildIndex, OUT PULONG ChildIndex OPTIONAL,
OUT PHCELL_INDEX CellIndex) OUT PHCELL_INDEX CellIndex)
{ {
PCELL_DATA CellData; PCELL_DATA CellData;

9
sdk/lib/cmlib/cmvalue.c
View file

@ -207,7 +207,7 @@ NTAPI
CmpAddValueToList(IN PHHIVE Hive, CmpAddValueToList(IN PHHIVE Hive,
IN HCELL_INDEX ValueCell, IN HCELL_INDEX ValueCell,
IN ULONG Index, IN ULONG Index,
IN ULONG Type, IN HSTORAGE_TYPE StorageType,
IN OUT PCHILD_LIST ChildList) IN OUT PCHILD_LIST ChildList)
{ {
HCELL_INDEX ListCell; HCELL_INDEX ListCell;
@ -223,6 +223,8 @@ CmpAddValueToList(IN PHHIVE Hive,
ChildCount++; ChildCount++;
if (ChildCount > 1) if (ChildCount > 1)
{ {
ASSERT(ChildList->List != HCELL_NIL);
/* The cell should be dirty at this point */ /* The cell should be dirty at this point */
ASSERT(HvIsCellDirty(Hive, ChildList->List)); ASSERT(HvIsCellDirty(Hive, ChildList->List));
@ -249,7 +251,8 @@ CmpAddValueToList(IN PHHIVE Hive,
else else
{ {
/* This is our first child, so allocate a single cell */ /* This is our first child, so allocate a single cell */
ListCell = HvAllocateCell(Hive, sizeof(HCELL_INDEX), Type, HCELL_NIL); ASSERT(ChildList->List == HCELL_NIL);
ListCell = HvAllocateCell(Hive, sizeof(HCELL_INDEX), StorageType, HCELL_NIL);
} }
/* Fail if we couldn't get a cell */ /* Fail if we couldn't get a cell */
@ -286,7 +289,7 @@ NTAPI
CmpSetValueDataNew(IN PHHIVE Hive, CmpSetValueDataNew(IN PHHIVE Hive,
IN PVOID Data, IN PVOID Data,
IN ULONG DataSize, IN ULONG DataSize,
IN ULONG StorageType, IN HSTORAGE_TYPE StorageType,
IN HCELL_INDEX ValueCell, IN HCELL_INDEX ValueCell,
OUT PHCELL_INDEX DataCell) OUT PHCELL_INDEX DataCell)
{ {