Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-06-04 00:40:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

[VIDEOPRT] Use ExFreePoolWithTag() + Add some ASSERTs.

Browse source
This commit is contained in:
Hermès Bélusca-Maïto 2019-11-25 00:32:28 +01:00
parent e930b868a0
commit bf74f101c2
No known key found for this signature in database
GPG key ID: 3B2539C65E7B93D0
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
win32ss/drivers/videoprt/agp.c
View file

@ -176,7 +176,7 @@ IntAgpReleasePhysical(
} }
/* Free resources */ /* Free resources */
ExFreePool(AgpMapping); ExFreePoolWithTag(AgpMapping, TAG_VIDEO_PORT);
} }
PHYSICAL_ADDRESS NTAPI PHYSICAL_ADDRESS NTAPI
@ -230,7 +230,7 @@ IntAgpReservePhysical(
&AgpMapping->PhysicalAddress); &AgpMapping->PhysicalAddress);
if (!NT_SUCCESS(Status) || AgpMapping->MapHandle == NULL) if (!NT_SUCCESS(Status) || AgpMapping->MapHandle == NULL)
{ {
ExFreePool(AgpMapping); ExFreePoolWithTag(AgpMapping, TAG_VIDEO_PORT);
WARN_(VIDEOPRT, "Warning: AgpBusInterface->ReserveMemory failed (Status = 0x%x)\n", WARN_(VIDEOPRT, "Warning: AgpBusInterface->ReserveMemory failed (Status = 0x%x)\n",
Status); Status);
return ZeroAddress; return ZeroAddress;
@ -412,7 +412,7 @@ IntAgpReleaseVirtual(
} }
/* Free resources */ /* Free resources */
ExFreePool(VirtualMapping); ExFreePoolWithTag(VirtualMapping, TAG_VIDEO_PORT);
} }
PVOID NTAPI PVOID NTAPI
@ -447,7 +447,7 @@ IntAgpReserveVirtual(
if (ProcessHandle == NULL) if (ProcessHandle == NULL)
{ {
/* FIXME: What to do in this case? */ /* FIXME: What to do in this case? */
ExFreePool(VirtualMapping); ExFreePoolWithTag(VirtualMapping, TAG_VIDEO_PORT);
return NULL; return NULL;
} }
else /* ProcessHandle != NULL */ else /* ProcessHandle != NULL */
@ -459,7 +459,7 @@ IntAgpReserveVirtual(
MEM_RESERVE, PAGE_NOACCESS); MEM_RESERVE, PAGE_NOACCESS);
if (!NT_SUCCESS(Status)) if (!NT_SUCCESS(Status))
{ {
ExFreePool(VirtualMapping); ExFreePoolWithTag(VirtualMapping, TAG_VIDEO_PORT);
WARN_(VIDEOPRT, "ZwAllocateVirtualMemory() failed: Status = 0x%x\n", Status); WARN_(VIDEOPRT, "ZwAllocateVirtualMemory() failed: Status = 0x%x\n", Status);
return NULL; return NULL;
} }

4
win32ss/drivers/videoprt/event.c
View file

@ -78,7 +78,7 @@ VideoPortDeleteEvent(
if (!Event->pKEvent) return ERROR_INVALID_PARAMETER; if (!Event->pKEvent) return ERROR_INVALID_PARAMETER;
/* Free storage */ /* Free storage */
ExFreePool(Event); ExFreePoolWithTag(Event, TAG_VIDEO_PORT);
/* Indicate success */ /* Indicate success */
return NO_ERROR; return NO_ERROR;
@ -93,6 +93,7 @@ VideoPortSetEvent(
_In_ PVOID HwDeviceExtension, _In_ PVOID HwDeviceExtension,
_In_ PEVENT Event) _In_ PEVENT Event)
{ {
ASSERT(Event);
return KeSetEvent(Event->pKEvent, IO_NO_INCREMENT, FALSE); return KeSetEvent(Event->pKEvent, IO_NO_INCREMENT, FALSE);
} }
@ -105,6 +106,7 @@ VideoPortClearEvent(
_In_ PVOID HwDeviceExtension, _In_ PVOID HwDeviceExtension,
_In_ PEVENT Event) _In_ PEVENT Event)
{ {
ASSERT(Event);
KeClearEvent(Event->pKEvent); KeClearEvent(Event->pKEvent);
} }