Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 01:55:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTUSER] Error of co_UserCreateWindowEx should display class name (#5682)

Browse source 
The error messsage of co_UserCreateWindowEx
was unfriendly to the debugger.
Show the window class name by using "%wZ" in
co_UserCreateWindowEx.
This commit is contained in:
Katayama Hirofumi MZ 2023-09-12 06:16:05 +09:00 committed by GitHub
parent 1961d708e7
commit bcd916bd4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
win32ss/user/ntuser/window.c
View file

@ -2194,7 +2194,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
pti = GetW32ThreadInfo(); pti = GetW32ThreadInfo();
if (pti == NULL || pti->rpdesk == NULL) if (pti == NULL || pti->rpdesk == NULL)
{ {
ERR("Thread is not attached to a desktop! Cannot create window!\n"); ERR("Thread is not attached to a desktop! Cannot create window (%wZ)\n", ClassName);
return NULL; // There is nothing to cleanup. return NULL; // There is nothing to cleanup.
} }
WinSta = pti->rpdesk->rpwinstaParent; WinSta = pti->rpdesk->rpwinstaParent;
@ -2229,7 +2229,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
} }
else if ((Cs->style & (WS_CHILD|WS_POPUP)) == WS_CHILD) else if ((Cs->style & (WS_CHILD|WS_POPUP)) == WS_CHILD)
{ {
ERR("Cannot create a child window without a parent!\n"); ERR("Cannot create a child window (%wZ) without a parent\n", ClassName);
EngSetLastError(ERROR_TLW_WITH_WSCHILD); EngSetLastError(ERROR_TLW_WITH_WSCHILD);
goto cleanup; /* WS_CHILD needs a parent, but WS_POPUP doesn't */ goto cleanup; /* WS_CHILD needs a parent, but WS_POPUP doesn't */
} }
@ -2249,12 +2249,12 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
if (hWndParent && !ParentWindow) if (hWndParent && !ParentWindow)
{ {
ERR("Got invalid parent window handle\n"); ERR("Got invalid parent window handle for %wZ\n", ClassName);
goto cleanup; goto cleanup;
} }
else if (hWndOwner && !OwnerWindow) else if (hWndOwner && !OwnerWindow)
{ {
ERR("Got invalid owner window handle\n"); ERR("Got invalid owner window handle for %wZ\n", ClassName);
ParentWindow = NULL; ParentWindow = NULL;
goto cleanup; goto cleanup;
} }
@ -2293,7 +2293,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
dwVer ); dwVer );
if(!Window) if(!Window)
{ {
ERR("IntCreateWindow failed!\n"); ERR("IntCreateWindow(%wZ) failed\n", ClassName);
goto cleanup; goto cleanup;
} }
@ -2419,7 +2419,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
Result = co_IntSendMessage(UserHMGetHandle(Window), WM_NCCREATE, 0, (LPARAM) Cs); Result = co_IntSendMessage(UserHMGetHandle(Window), WM_NCCREATE, 0, (LPARAM) Cs);
if (!Result) if (!Result)
{ {
ERR("co_UserCreateWindowEx(): NCCREATE message failed\n"); ERR("co_UserCreateWindowEx(%wZ): NCCREATE message failed\n", ClassName);
goto cleanup; goto cleanup;
} }
@ -2479,7 +2479,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
Result = co_IntSendMessage(UserHMGetHandle(Window), WM_CREATE, 0, (LPARAM) Cs); Result = co_IntSendMessage(UserHMGetHandle(Window), WM_CREATE, 0, (LPARAM) Cs);
if (Result == (LRESULT)-1) if (Result == (LRESULT)-1)
{ {
ERR("co_UserCreateWindowEx(): WM_CREATE message failed\n"); ERR("co_UserCreateWindowEx(%wZ): WM_CREATE message failed\n", ClassName);
goto cleanup; goto cleanup;
} }
@ -2570,7 +2570,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
co_IntUserManualGuiCheck(TRUE); co_IntUserManualGuiCheck(TRUE);
} }
TRACE("co_UserCreateWindowEx(): Created window %p\n", hWnd); TRACE("co_UserCreateWindowEx(%wZ): Created window %p\n", ClassName, hWnd);
ret = Window; ret = Window;
cleanup: cleanup: