Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-06-11 04:47:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SHELL32] Show properties dialog in a new thread

Browse source
This commit is contained in:
Mark Jansen 2022-02-03 23:23:33 +01:00
parent 93fac5533d
commit bc5603d9d0
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
1 changed files with 62 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

85
dll/win32/shell32/shlfolder.cpp
View file

@ -26,6 +26,24 @@
WINE_DEFAULT_DEBUG_CHANNEL(shell); WINE_DEFAULT_DEBUG_CHANNEL(shell);
static
HRESULT WINAPI _SHBindToFolder(LPCITEMIDLIST path, IShellFolder** newFolder)
{
CComPtr<IShellFolder> desktop;
HRESULT hr = ::SHGetDesktopFolder(&desktop);
if (FAILED_UNEXPECTEDLY(hr))
return E_FAIL;
if (path == NULL || path->mkid.cb == 0)
{
*newFolder = desktop;
desktop.p->AddRef();
return S_OK;
}
return desktop->BindToObject(path, NULL, IID_PPV_ARG(IShellFolder, newFolder));
}
/*************************************************************************** /***************************************************************************
* GetNextElement (internal function) * GetNextElement (internal function)
* *
@ -422,33 +440,39 @@ SHOpenFolderAndSelectItems(PCIDLIST_ABSOLUTE pidlFolder,
return E_FAIL; return E_FAIL;
} }
/*
* for internal use
*/
HRESULT WINAPI
Shell_DefaultContextMenuCallBack(IShellFolder *psf, IDataObject *pdtobj)
{
PIDLIST_ABSOLUTE pidlFolder;
PUITEMID_CHILD *apidl;
UINT cidl;
HRESULT hr = SH_GetApidlFromDataObject(pdtobj, &pidlFolder, &apidl, &cidl);
if (FAILED_UNEXPECTEDLY(hr))
return hr;
if (cidl > 1)
static
DWORD WINAPI
_ShowPropertiesDialogThread(LPVOID lpParameter)
{
CComPtr<IDataObject> pDataObject;
pDataObject.Attach((IDataObject*)lpParameter);
CDataObjectHIDA cida(pDataObject);
if (FAILED_UNEXPECTEDLY(cida.hr()))
return cida.hr();
if (cida->cidl > 1)
{ {
ERR("SHMultiFileProperties is not yet implemented\n"); ERR("SHMultiFileProperties is not yet implemented\n");
SHFree(pidlFolder);
_ILFreeaPidl(apidl, cidl);
return E_FAIL; return E_FAIL;
} }
PCUIDLIST_ABSOLUTE pidlFolder = HIDA_GetPIDLFolder(cida);
CComPtr<IShellFolder> psfParent;
HRESULT hr = _SHBindToFolder(pidlFolder, &psfParent);
if (FAILED_UNEXPECTEDLY(hr))
return hr;
STRRET strFile; STRRET strFile;
hr = psf->GetDisplayNameOf(apidl[0], SHGDN_FORPARSING, &strFile); PCUIDLIST_RELATIVE apidl = HIDA_GetPIDLItem(cida, 0);
if (SUCCEEDED(hr)) hr = psfParent->GetDisplayNameOf(apidl, SHGDN_FORPARSING, &strFile);
if (!FAILED_UNEXPECTEDLY(hr))
{ {
hr = SH_ShowPropertiesDialog(strFile.pOleStr, pidlFolder, apidl); BOOL bSuccess = SH_ShowPropertiesDialog(strFile.pOleStr, pidlFolder, &apidl);
if (FAILED(hr)) if (!bSuccess)
ERR("SH_ShowPropertiesDialog failed\n"); ERR("SH_ShowPropertiesDialog failed\n");
} }
else else
@ -456,8 +480,23 @@ Shell_DefaultContextMenuCallBack(IShellFolder *psf, IDataObject *pdtobj)
ERR("Failed to get display name\n"); ERR("Failed to get display name\n");
} }
SHFree(pidlFolder); return 0;
_ILFreeaPidl(apidl, cidl); }
return hr; /*
* for internal use
*/
HRESULT WINAPI
Shell_DefaultContextMenuCallBack(IShellFolder *psf, IDataObject *pdtobj)
{
pdtobj->AddRef();
if (!SHCreateThread(_ShowPropertiesDialogThread, pdtobj, CTF_INSIST | CTF_COINIT, NULL))
{
pdtobj->Release();
return HRESULT_FROM_WIN32(GetLastError());
}
else
{
return S_OK;
}
} }