Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 18:15:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

[DC21X4] Fix minor issues (#6161)

Browse source 
- The return value got lost when refactoring the setup function
- The check against 0xFFFFFFFF was meant to reject an empty EEPROM image
- Add missing PAGED_CODE(); macros

CORE-8724
This commit is contained in:
Dmitry Borisov 2023-12-17 15:00:25 +06:00 committed by GitHub
parent f7d612f3e3
commit bbe6b07612
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/network/dd/dc21x4/eeprom.c
View file

@ -859,6 +859,8 @@ AddressRomChecksumValid(
ULONG64 TestPatterm; ULONG64 TestPatterm;
ULONG Checksum, i; ULONG Checksum, i;
PAGED_CODE();
NdisMoveMemory(&TestPatterm, &Octet[24], 8); NdisMoveMemory(&TestPatterm, &Octet[24], 8);
if (TestPatterm != EAR_TEST_PATTERN) if (TestPatterm != EAR_TEST_PATTERN)
return FALSE; return FALSE;
@ -886,6 +888,8 @@ SRomReadMacAddress(
{ {
ULONG MacOffset; ULONG MacOffset;
PAGED_CODE();
/* Check if we have a board with an old EAR format */ /* Check if we have a board with an old EAR format */
if (NdisEqualMemory(SRom, &SRom[16], 8)) if (NdisEqualMemory(SRom, &SRom[16], 8))
{ {
@ -912,7 +916,7 @@ SRomReadMacAddress(
} }
/* Sanity check */ /* Sanity check */
if (*(PULONG)SRom == 0xFFFFFFF || *(PULONG)SRom == 0) if (*(PULONG)SRom == 0xFFFFFFFF || *(PULONG)SRom == 0)
return FALSE; return FALSE;
WARN("Legacy/unknown board found\n"); WARN("Legacy/unknown board found\n");

2
drivers/network/dd/dc21x4/power.c
View file

@ -146,7 +146,7 @@ DcPowerUp(
/* Re-initialize the chip to leave D3 state */ /* Re-initialize the chip to leave D3 state */
if (Adapter->PrevPowerState == NdisDeviceStateD3) if (Adapter->PrevPowerState == NdisDeviceStateD3)
{ {
NT_VERIFY(DcSetupAdapter(Adapter) == TRUE); NT_VERIFY(DcSetupAdapter(Adapter) == NDIS_STATUS_SUCCESS);
} }
else else
{ {