Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-07-31 21:11:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS]

Browse source 
- Fix CcMdlReadComplete2 prototype.
- Fix a bug in Dominique Cote's code: when performing FsRtlGetFileSize, the length of the buffer should be set accordingly to the information class asked for, that is - FILE_STANDARD_INFORMATION structure. Previous calculation formula makes no sense at all and leads to memory corruption (if filesystem driver is stupid enough) or inability to get file size (if filesystem driver is coded by good developers).

svn path=/trunk/; revision=59495
This commit is contained in:
Aleksey Bragin 2013-07-16 22:37:01 +00:00
parent ee87f2a4f6
commit b666ebecda
5 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
reactos/ntoskrnl/cache/mdlsup.c vendored
View file

@ -80,8 +80,8 @@ CcMdlReadComplete(IN PFILE_OBJECT FileObject,
VOID VOID
NTAPI NTAPI
CcMdlReadComplete2(IN PMDL MdlChain, CcMdlReadComplete2(IN PFILE_OBJECT FileObject,
IN PFILE_OBJECT FileObject) IN PMDL MdlChain)
{ {
UNIMPLEMENTED UNIMPLEMENTED
} }

4
reactos/ntoskrnl/cache/newcc.h vendored
View file

@ -44,8 +44,8 @@ CcPfInitializePrefetcher(VOID);
VOID VOID
NTAPI NTAPI
CcMdlReadComplete2(IN PMDL MemoryDescriptorList, CcMdlReadComplete2(IN PFILE_OBJECT FileObject,
IN PFILE_OBJECT FileObject); IN PMDL MemoryDescriptorList);
VOID VOID
NTAPI NTAPI

7
reactos/ntoskrnl/cc/mdl.c
View file

@ -51,8 +51,9 @@ CcMdlRead (
VOID VOID
NTAPI NTAPI
CcMdlReadComplete2 ( CcMdlReadComplete2 (
IN PMDL MemoryDescriptorList, IN PFILE_OBJECT FileObject,
IN PFILE_OBJECT FileObject) IN PMDL MemoryDescriptorList
)
{ {
PMDL Mdl; PMDL Mdl;
@ -104,7 +105,7 @@ CcMdlReadComplete (
} }
/* Use slow path */ /* Use slow path */
CcMdlReadComplete2(MdlChain, FileObject); CcMdlReadComplete2(FileObject, MdlChain);
} }
/* /*

4
reactos/ntoskrnl/fsrtl/fastio.c
View file

@ -880,7 +880,7 @@ FsRtlGetFileSize(IN PFILE_OBJECT FileObject,
IoStackLocation->FileObject = FileObject; IoStackLocation->FileObject = FileObject;
IoStackLocation->DeviceObject = DeviceObject; IoStackLocation->DeviceObject = DeviceObject;
IoStackLocation->Parameters.QueryFile.Length = IoStackLocation->Parameters.QueryFile.Length =
ALIGN_UP(sizeof(FILE_INFORMATION_CLASS), ULONG); sizeof(FILE_STANDARD_INFORMATION);
IoStackLocation->Parameters.QueryFile.FileInformationClass = IoStackLocation->Parameters.QueryFile.FileInformationClass =
FileStandardInformation; FileStandardInformation;
@ -1019,7 +1019,7 @@ FsRtlMdlReadCompleteDev(IN PFILE_OBJECT FileObject,
IN PDEVICE_OBJECT DeviceObject) IN PDEVICE_OBJECT DeviceObject)
{ {
/* Call the Cache Manager */ /* Call the Cache Manager */
CcMdlReadComplete2(MemoryDescriptorList, FileObject); CcMdlReadComplete2(FileObject, MemoryDescriptorList);
return TRUE; return TRUE;
} }

4
reactos/ntoskrnl/include/internal/cc.h
View file

@ -172,8 +172,8 @@ CcPfInitializePrefetcher(
VOID VOID
NTAPI NTAPI
CcMdlReadComplete2( CcMdlReadComplete2(
IN PMDL MemoryDescriptorList, IN PFILE_OBJECT FileObject,
IN PFILE_OBJECT FileObject IN PMDL MemoryDescriptorList
); );
VOID VOID