Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-30 06:28:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

[KDBG] Fixed handle leak in KdbpSymLoadModuleSymbols() when RosSymCreateFromFile() fails (#3184)

Browse source
This commit is contained in:
Michael Stamper 2020-09-14 20:48:06 +01:00 committed by GitHub
parent 6d7ebc2048
commit b43e4c981e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ntoskrnl/kdbg/kdb_symbols.c
View file

@ -363,6 +363,7 @@ KdbpSymLoadModuleSymbols(
HANDLE FileHandle; HANDLE FileHandle;
NTSTATUS Status; NTSTATUS Status;
IO_STATUS_BLOCK IoStatusBlock; IO_STATUS_BLOCK IoStatusBlock;
BOOLEAN Result;
/* Allow KDB to break on module load */ /* Allow KDB to break on module load */
KdbModuleLoaded(FileName); KdbModuleLoaded(FileName);
@ -404,14 +405,15 @@ KdbpSymLoadModuleSymbols(
DPRINT("Loading symbols from %wZ...\n", FileName); DPRINT("Loading symbols from %wZ...\n", FileName);
if (!RosSymCreateFromFile(&FileHandle, RosSymInfo)) Result = RosSymCreateFromFile(&FileHandle, RosSymInfo);
ZwClose(FileHandle);
if (!Result)
{ {
DPRINT("Failed to load symbols from %wZ\n", FileName); DPRINT("Failed to load symbols from %wZ\n", FileName);
return; return;
} }
ZwClose(FileHandle);
DPRINT("Symbols loaded.\n"); DPRINT("Symbols loaded.\n");
/* add file to cache */ /* add file to cache */