Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-06-04 00:40:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

[USERENV]: Code formatting

Browse source 
svn path=/trunk/; revision=73439
This commit is contained in:
Hermès Bélusca-Maïto 2016-12-08 16:08:59 +00:00
parent d6e721c82f
commit b0107a6173
1 changed files with 36 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

98
reactos/dll/win32/userenv/environment.c
View file

@ -36,25 +36,23 @@ SetUserEnvironmentVariable(LPVOID *Environment,
LPWSTR lpValue, LPWSTR lpValue,
BOOL bExpand) BOOL bExpand)
{ {
WCHAR ShortName[MAX_PATH]; NTSTATUS Status;
UNICODE_STRING Name; UNICODE_STRING Name;
UNICODE_STRING SrcValue; UNICODE_STRING SrcValue;
UNICODE_STRING DstValue; UNICODE_STRING DstValue;
ULONG Length; ULONG Length;
NTSTATUS Status;
PVOID Buffer = NULL; PVOID Buffer = NULL;
WCHAR ShortName[MAX_PATH];
if (bExpand) if (bExpand)
{ {
RtlInitUnicodeString(&SrcValue, RtlInitUnicodeString(&SrcValue, lpValue);
lpValue);
Length = 2 * MAX_PATH * sizeof(WCHAR); Length = 2 * MAX_PATH * sizeof(WCHAR);
DstValue.Length = 0; DstValue.Length = 0;
DstValue.MaximumLength = Length; DstValue.MaximumLength = Length;
DstValue.Buffer = Buffer = LocalAlloc(LPTR, DstValue.Buffer = Buffer = LocalAlloc(LPTR, Length);
Length);
if (DstValue.Buffer == NULL) if (DstValue.Buffer == NULL)
{ {
DPRINT1("LocalAlloc() failed\n"); DPRINT1("LocalAlloc() failed\n");
@ -69,15 +67,16 @@ SetUserEnvironmentVariable(LPVOID *Environment,
{ {
DPRINT1("RtlExpandEnvironmentStrings_U() failed (Status %lx)\n", Status); DPRINT1("RtlExpandEnvironmentStrings_U() failed (Status %lx)\n", Status);
DPRINT1("Length %lu\n", Length); DPRINT1("Length %lu\n", Length);
if (Buffer) if (Buffer)
LocalFree(Buffer); LocalFree(Buffer);
return FALSE; return FALSE;
} }
} }
else else
{ {
RtlInitUnicodeString(&DstValue, RtlInitUnicodeString(&DstValue, lpValue);
lpValue);
} }
if (!_wcsicmp(lpName, L"temp") || !_wcsicmp(lpName, L"tmp")) if (!_wcsicmp(lpName, L"temp") || !_wcsicmp(lpName, L"tmp"))
@ -86,15 +85,13 @@ SetUserEnvironmentVariable(LPVOID *Environment,
{ {
DPRINT("GetShortPathNameW() failed for %S (Error %lu)\n", DstValue.Buffer, GetLastError()); DPRINT("GetShortPathNameW() failed for %S (Error %lu)\n", DstValue.Buffer, GetLastError());
RtlInitUnicodeString(&DstValue, RtlInitUnicodeString(&DstValue, ShortName);
ShortName);
} }
DPRINT("Buffer: %S\n", ShortName); DPRINT("Buffer: %S\n", ShortName);
} }
RtlInitUnicodeString(&Name, RtlInitUnicodeString(&Name, lpName);
lpName);
DPRINT("Value: %wZ\n", &DstValue); DPRINT("Value: %wZ\n", &DstValue);
@ -121,34 +118,27 @@ AppendUserEnvironmentVariable(LPVOID *Environment,
LPWSTR lpName, LPWSTR lpName,
LPWSTR lpValue) LPWSTR lpValue)
{ {
NTSTATUS Status;
UNICODE_STRING Name; UNICODE_STRING Name;
UNICODE_STRING Value; UNICODE_STRING Value;
NTSTATUS Status;
RtlInitUnicodeString(&Name, RtlInitUnicodeString(&Name, lpName);
lpName);
Value.Length = 0; Value.Length = 0;
Value.MaximumLength = 1024 * sizeof(WCHAR); Value.MaximumLength = 1024 * sizeof(WCHAR);
Value.Buffer = LocalAlloc(LPTR, Value.Buffer = LocalAlloc(LPTR, Value.MaximumLength);
1024 * sizeof(WCHAR));
if (Value.Buffer == NULL) if (Value.Buffer == NULL)
{
return FALSE; return FALSE;
}
Value.Buffer[0] = UNICODE_NULL; Value.Buffer[0] = UNICODE_NULL;
Status = RtlQueryEnvironmentVariable_U((PWSTR)*Environment, Status = RtlQueryEnvironmentVariable_U((PWSTR)*Environment,
&Name, &Name,
&Value); &Value);
if (NT_SUCCESS(Status)) if (NT_SUCCESS(Status))
{ RtlAppendUnicodeToString(&Value, L";");
RtlAppendUnicodeToString(&Value,
L";");
}
RtlAppendUnicodeToString(&Value, RtlAppendUnicodeToString(&Value, lpValue);
lpValue);
Status = RtlSetEnvironmentVariable((PWSTR*)Environment, Status = RtlSetEnvironmentVariable((PWSTR*)Environment,
&Name, &Name,
@ -168,12 +158,11 @@ static
HKEY HKEY
GetCurrentUserKey(HANDLE hToken) GetCurrentUserKey(HANDLE hToken)
{ {
LONG Error;
UNICODE_STRING SidString; UNICODE_STRING SidString;
HKEY hKey; HKEY hKey;
LONG Error;
if (!GetUserSidStringFromToken(hToken, if (!GetUserSidStringFromToken(hToken, &SidString))
&SidString))
{ {
DPRINT1("GetUserSidFromToken() failed\n"); DPRINT1("GetUserSidFromToken() failed\n");
return NULL; return NULL;
@ -204,13 +193,13 @@ GetUserAndDomainName(IN HANDLE hToken,
OUT LPWSTR *UserName, OUT LPWSTR *UserName,
OUT LPWSTR *DomainName) OUT LPWSTR *DomainName)
{ {
BOOL bRet = TRUE;
PSID Sid = NULL; PSID Sid = NULL;
LPWSTR lpUserName = NULL; LPWSTR lpUserName = NULL;
LPWSTR lpDomainName = NULL; LPWSTR lpDomainName = NULL;
DWORD cbUserName = 0; DWORD cbUserName = 0;
DWORD cbDomainName = 0; DWORD cbDomainName = 0;
SID_NAME_USE SidNameUse; SID_NAME_USE SidNameUse;
BOOL bRet = TRUE;
Sid = GetUserSid(hToken); Sid = GetUserSid(hToken);
if (Sid == NULL) if (Sid == NULL)
@ -234,16 +223,14 @@ GetUserAndDomainName(IN HANDLE hToken,
} }
} }
lpUserName = LocalAlloc(LPTR, lpUserName = LocalAlloc(LPTR, cbUserName * sizeof(WCHAR));
cbUserName * sizeof(WCHAR));
if (lpUserName == NULL) if (lpUserName == NULL)
{ {
bRet = FALSE; bRet = FALSE;
goto done; goto done;
} }
lpDomainName = LocalAlloc(LPTR, lpDomainName = LocalAlloc(LPTR, cbDomainName * sizeof(WCHAR));
cbDomainName * sizeof(WCHAR));
if (lpDomainName == NULL) if (lpDomainName == NULL)
{ {
bRet = FALSE; bRet = FALSE;
@ -287,6 +274,7 @@ SetUserEnvironment(LPVOID *lpEnvironment,
HKEY hKey, HKEY hKey,
LPWSTR lpSubKeyName) LPWSTR lpSubKeyName)
{ {
LONG Error;
HKEY hEnvKey; HKEY hEnvKey;
DWORD dwValues; DWORD dwValues;
DWORD dwMaxValueNameLength; DWORD dwMaxValueNameLength;
@ -297,7 +285,6 @@ SetUserEnvironment(LPVOID *lpEnvironment,
DWORD i; DWORD i;
LPWSTR lpValueName; LPWSTR lpValueName;
LPWSTR lpValueData; LPWSTR lpValueData;
LONG Error;
Error = RegOpenKeyExW(hKey, Error = RegOpenKeyExW(hKey,
lpSubKeyName, lpSubKeyName,
@ -339,16 +326,14 @@ SetUserEnvironment(LPVOID *lpEnvironment,
/* Allocate buffers */ /* Allocate buffers */
dwMaxValueNameLength++; dwMaxValueNameLength++;
lpValueName = LocalAlloc(LPTR, lpValueName = LocalAlloc(LPTR, dwMaxValueNameLength * sizeof(WCHAR));
dwMaxValueNameLength * sizeof(WCHAR));
if (lpValueName == NULL) if (lpValueName == NULL)
{ {
RegCloseKey(hEnvKey); RegCloseKey(hEnvKey);
return FALSE; return FALSE;
} }
lpValueData = LocalAlloc(LPTR, lpValueData = LocalAlloc(LPTR, dwMaxValueDataLength);
dwMaxValueDataLength);
if (lpValueData == NULL) if (lpValueData == NULL)
{ {
LocalFree(lpValueName); LocalFree(lpValueName);
@ -410,6 +395,7 @@ static
BOOL BOOL
SetSystemEnvironment(LPVOID *lpEnvironment) SetSystemEnvironment(LPVOID *lpEnvironment)
{ {
LONG Error;
HKEY hEnvKey; HKEY hEnvKey;
DWORD dwValues; DWORD dwValues;
DWORD dwMaxValueNameLength; DWORD dwMaxValueNameLength;
@ -420,7 +406,6 @@ SetSystemEnvironment(LPVOID *lpEnvironment)
DWORD i; DWORD i;
LPWSTR lpValueName; LPWSTR lpValueName;
LPWSTR lpValueData; LPWSTR lpValueData;
LONG Error;
Error = RegOpenKeyExW(HKEY_LOCAL_MACHINE, Error = RegOpenKeyExW(HKEY_LOCAL_MACHINE,
L"SYSTEM\\CurrentControlSet\\Control\\Session Manager\\Environment", L"SYSTEM\\CurrentControlSet\\Control\\Session Manager\\Environment",
@ -460,16 +445,14 @@ SetSystemEnvironment(LPVOID *lpEnvironment)
/* Allocate buffers */ /* Allocate buffers */
dwMaxValueNameLength++; dwMaxValueNameLength++;
lpValueName = LocalAlloc(LPTR, lpValueName = LocalAlloc(LPTR, dwMaxValueNameLength * sizeof(WCHAR));
dwMaxValueNameLength * sizeof(WCHAR));
if (lpValueName == NULL) if (lpValueName == NULL)
{ {
RegCloseKey(hEnvKey); RegCloseKey(hEnvKey);
return FALSE; return FALSE;
} }
lpValueData = LocalAlloc(LPTR, lpValueData = LocalAlloc(LPTR, dwMaxValueDataLength);
dwMaxValueDataLength);
if (lpValueData == NULL) if (lpValueData == NULL)
{ {
LocalFree(lpValueName); LocalFree(lpValueName);
@ -523,16 +506,16 @@ CreateEnvironmentBlock(LPVOID *lpEnvironment,
HANDLE hToken, HANDLE hToken,
BOOL bInherit) BOOL bInherit)
{ {
WCHAR Buffer[MAX_PATH]; NTSTATUS Status;
WCHAR szValue[1024]; LONG lError;
DWORD Length; DWORD Length;
DWORD dwType; DWORD dwType;
HKEY hKey; HKEY hKey;
HKEY hKeyUser; HKEY hKeyUser;
LPWSTR lpUserName = NULL; LPWSTR lpUserName = NULL;
LPWSTR lpDomainName = NULL; LPWSTR lpDomainName = NULL;
NTSTATUS Status; WCHAR Buffer[MAX_PATH];
LONG lError; WCHAR szValue[1024];
DPRINT("CreateEnvironmentBlock() called\n"); DPRINT("CreateEnvironmentBlock() called\n");
@ -667,9 +650,7 @@ CreateEnvironmentBlock(LPVOID *lpEnvironment,
/* Set 'USERPROFILE' variable */ /* Set 'USERPROFILE' variable */
Length = MAX_PATH; Length = MAX_PATH;
if (GetUserProfileDirectoryW(hToken, if (GetUserProfileDirectoryW(hToken, Buffer, &Length))
Buffer,
&Length))
{ {
DWORD MinLen = 2; DWORD MinLen = 2;
@ -765,8 +746,8 @@ ExpandEnvironmentStringsForUserW(IN HANDLE hToken,
OUT LPWSTR lpDest, OUT LPWSTR lpDest,
IN DWORD dwSize) IN DWORD dwSize)
{ {
PVOID lpEnvironment;
BOOL Ret = FALSE; BOOL Ret = FALSE;
PVOID lpEnvironment;
if (lpSrc == NULL || lpDest == NULL || dwSize == 0) if (lpSrc == NULL || lpDest == NULL || dwSize == 0)
{ {
@ -781,14 +762,13 @@ ExpandEnvironmentStringsForUserW(IN HANDLE hToken,
UNICODE_STRING SrcU, DestU; UNICODE_STRING SrcU, DestU;
NTSTATUS Status; NTSTATUS Status;
/* initialize the strings */ /* Initialize the strings */
RtlInitUnicodeString(&SrcU, RtlInitUnicodeString(&SrcU, lpSrc);
lpSrc);
DestU.Length = 0; DestU.Length = 0;
DestU.MaximumLength = dwSize * sizeof(WCHAR); DestU.MaximumLength = dwSize * sizeof(WCHAR);
DestU.Buffer = lpDest; DestU.Buffer = lpDest;
/* expand the strings */ /* Expand the strings */
Status = RtlExpandEnvironmentStrings_U((PWSTR)lpEnvironment, Status = RtlExpandEnvironmentStrings_U((PWSTR)lpEnvironment,
&SrcU, &SrcU,
&DestU, &DestU,
@ -817,9 +797,9 @@ ExpandEnvironmentStringsForUserA(IN HANDLE hToken,
OUT LPSTR lpDest, OUT LPSTR lpDest,
IN DWORD dwSize) IN DWORD dwSize)
{ {
BOOL Ret = FALSE;
DWORD dwSrcLen; DWORD dwSrcLen;
LPWSTR lpSrcW = NULL, lpDestW = NULL; LPWSTR lpSrcW = NULL, lpDestW = NULL;
BOOL Ret = FALSE;
if (lpSrc == NULL || lpDest == NULL || dwSize == 0) if (lpSrc == NULL || lpDest == NULL || dwSize == 0)
{ {
@ -844,9 +824,7 @@ ExpandEnvironmentStringsForUserA(IN HANDLE hToken,
lpDestW = (LPWSTR)GlobalAlloc(GMEM_FIXED, lpDestW = (LPWSTR)GlobalAlloc(GMEM_FIXED,
dwSize * sizeof(WCHAR)); dwSize * sizeof(WCHAR));
if (lpDestW == NULL) if (lpDestW == NULL)
{
goto Cleanup; goto Cleanup;
}
Ret = ExpandEnvironmentStringsForUserW(hToken, Ret = ExpandEnvironmentStringsForUserW(hToken,
lpSrcW, lpSrcW,
@ -869,14 +847,10 @@ ExpandEnvironmentStringsForUserA(IN HANDLE hToken,
Cleanup: Cleanup:
if (lpSrcW != NULL) if (lpSrcW != NULL)
{
GlobalFree((HGLOBAL)lpSrcW); GlobalFree((HGLOBAL)lpSrcW);
}
if (lpDestW != NULL) if (lpDestW != NULL)
{
GlobalFree((HGLOBAL)lpDestW); GlobalFree((HGLOBAL)lpDestW);
}
return Ret; return Ret;
} }