Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-10-06 09:24:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove more hardcode buffer value to dymatic buffer.

Browse source 
svn path=/trunk/; revision=17628
This commit is contained in:
Magnus Olsen 2005-09-04 09:54:59 +00:00
parent 1cb2b6830e
commit adb5d8466f
1 changed files with 37 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
reactos/subsys/system/cmd/cmd.c
View file

@ -296,9 +296,9 @@ static VOID
Execute (LPTSTR Full, LPTSTR First, LPTSTR Rest) Execute (LPTSTR Full, LPTSTR First, LPTSTR Rest)
{ {
TCHAR szFullName[MAX_PATH]; TCHAR szFullName[MAX_PATH];
TCHAR first[CMDLINE_LENGTH]; TCHAR *first = NULL;
TCHAR rest[CMDLINE_LENGTH]; TCHAR *rest = NULL;
TCHAR full[CMDLINE_LENGTH]; TCHAR *full = NULL;
#ifndef __REACTOS__ #ifndef __REACTOS__
TCHAR szWindowTitle[MAX_PATH]; TCHAR szWindowTitle[MAX_PATH];
#endif #endif
@ -308,10 +308,39 @@ Execute (LPTSTR Full, LPTSTR First, LPTSTR Rest)
DebugPrintf (_T("Execute: \'%s\' \'%s\'\n"), first, rest); DebugPrintf (_T("Execute: \'%s\' \'%s\'\n"), first, rest);
#endif #endif
/* we need biger buffer that First, Rest, Full are already
need rewrite some code to use realloc when it need instead
of add 512bytes extra */
first = malloc ( _tcslen(First) + 512 * sizeof(TCHAR));
if (first == NULL)
{
error_out_of_memory();
return ;
}
rest = malloc ( _tcslen(Rest) + 512 * sizeof(TCHAR));
if (rest == NULL)
{
free (full);
error_out_of_memory();
return ;
}
full = malloc ( _tcslen(Full) + 512 * sizeof(TCHAR));
if (full == NULL)
{
free (full);
free (rest);
error_out_of_memory();
return ;
}
/* Though it was already parsed once, we have a different set of rules /* Though it was already parsed once, we have a different set of rules
for parsing before we pass to CreateProccess */ for parsing before we pass to CreateProccess */
if(!_tcschr(Full,_T('\"'))) if(!_tcschr(Full,_T('\"')))
{ {
_tcscpy(first,First); _tcscpy(first,First);
_tcscpy(rest,Rest); _tcscpy(rest,Rest);
_tcscpy(full,Full); _tcscpy(full,Full);
@ -468,6 +497,10 @@ Execute (LPTSTR Full, LPTSTR First, LPTSTR Rest)
#ifndef __REACTOS__ #ifndef __REACTOS__
SetConsoleTitle (szWindowTitle); SetConsoleTitle (szWindowTitle);
#endif #endif
free(first);
free(rest);
free(full);
} }