From abd4c818dc26802a01a044d054702741b21f2965 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?= Date: Wed, 21 Apr 2021 19:48:58 +0200 Subject: [PATCH] [CSRSRV] Fix uninitialized variable warning detected by Clang. (#3619) CORE-17545 subsystems/win32/csrsrv/api.c:63:9: warning: variable 'ServerDll' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized] if ((ServerId >= CSR_SERVER_DLL_MAX) || ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ subsystems/win32/csrsrv/api.c:67:76: note: uninitialized use occurs here DPRINT1("CSRSS: %lx is invalid ServerDllIndex (%08x)\n", ServerId, ServerDll); ^~~~~~~~~ --- subsystems/win32/csrsrv/api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subsystems/win32/csrsrv/api.c b/subsystems/win32/csrsrv/api.c index 39229a1b384..07b8db3749c 100644 --- a/subsystems/win32/csrsrv/api.c +++ b/subsystems/win32/csrsrv/api.c @@ -52,7 +52,7 @@ CsrCallServerFromServer(IN PCSR_API_MESSAGE ReceiveMsg, IN OUT PCSR_API_MESSAGE ReplyMsg) { ULONG ServerId; - PCSR_SERVER_DLL ServerDll; + PCSR_SERVER_DLL ServerDll = NULL; ULONG ApiId; CSR_REPLY_CODE ReplyCode = CsrReplyImmediately;