Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 20:35:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

[KERNEL32]: Simplify CreateMemoryResourceNotification and bring up to ReactOS coding standards.

Browse source 
[KERNEL32]: Bug: QueryMemoryResourceNotification should set ERROR_INVALID_PARAMETER and fail if the Handle is NULL or INVALID_HANDLE_VALUE.
[KERNEL32]: Fix ULONG<->BOOL cast in QueryMemoryResourceNotification as well.

svn path=/trunk/; revision=52817
This commit is contained in:
Alex Ionescu 2011-07-23 18:50:20 +00:00
parent 3f6d71af42
commit ab6e9909fe
1 changed files with 36 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

80
reactos/dll/win32/kernel32/client/resntfy.c
View file

@ -1,49 +1,42 @@
/* $Id$
*
/*
* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS kernel
* FILE: lib/kernel32/mem/resnotify.c
* PURPOSE: Memory Resource Notification
* PROJECT: ReactOS Win32 Base API
* FILE: dll/win32/kernel32/client/resnotify.c
* PURPOSE: Memory Resource Notifications
* PROGRAMMER: Thomas Weidenmueller <w3seek@reactos.com>
*/
/* INCLUDES ******************************************************************/
/* INCLUDES *******************************************************************/
#include <k32.h>
#define NDEBUG
#include <debug.h>
/* FUNCTIONS *****************************************************************/
/* FUNCTIONS ******************************************************************/
/*
* @implemented
*/
HANDLE
WINAPI
CreateMemoryResourceNotification(
MEMORY_RESOURCE_NOTIFICATION_TYPE NotificationType
)
CreateMemoryResourceNotification(IN MEMORY_RESOURCE_NOTIFICATION_TYPE NotificationType)
{
UNICODE_STRING EventName;
OBJECT_ATTRIBUTES ObjectAttributes;
HANDLE hEvent;
NTSTATUS Status;
switch(NotificationType)
if (NotificationType > HighMemoryResourceNotification)
{
case LowMemoryResourceNotification:
RtlInitUnicodeString(&EventName, L"\\KernelObjects\\LowMemoryCondition");
break;
case HighMemoryResourceNotification:
RtlInitUnicodeString(&EventName, L"\\KernelObjects\\HighMemoryCondition");
break;
default:
SetLastError(ERROR_INVALID_PARAMETER);
return NULL;
}
RtlInitUnicodeString(&EventName,
NotificationType ?
L"\\KernelObjects\\HighMemoryCondition" :
L"\\KernelObjects\\LowMemoryCondition");
InitializeObjectAttributes(&ObjectAttributes,
&EventName,
@ -54,47 +47,46 @@ CreateMemoryResourceNotification(
Status = NtOpenEvent(&hEvent,
EVENT_QUERY_STATE | SYNCHRONIZE,
&ObjectAttributes);
if(!NT_SUCCESS(Status))
if (!NT_SUCCESS(Status))
{
SetLastErrorByStatus(Status);
return NULL;
SetLastErrorByStatus(Status);
return NULL;
}
return hEvent;
}
/*
* @implemented
*/
BOOL
WINAPI
QueryMemoryResourceNotification(
HANDLE ResourceNotificationHandle,
PBOOL ResourceState
)
QueryMemoryResourceNotification(IN HANDLE ResourceNotificationHandle,
OUT PBOOL ResourceState)
{
EVENT_BASIC_INFORMATION ebi;
EVENT_BASIC_INFORMATION EventInfo;
NTSTATUS Status;
if(ResourceState != NULL)
if ((ResourceNotificationHandle) &&
(ResourceNotificationHandle != INVALID_HANDLE_VALUE) &&
(ResourceState))
{
Status = NtQueryEvent(ResourceNotificationHandle,
EventBasicInformation,
&ebi,
sizeof(ebi),
NULL);
if(NT_SUCCESS(Status))
{
*ResourceState = ebi.EventState;
return TRUE;
}
Status = NtQueryEvent(ResourceNotificationHandle,
EventBasicInformation,
&EventInfo,
sizeof(EventInfo),
NULL);
if (NT_SUCCESS(Status))
{
*ResourceState = (EventInfo.EventState == 1);
return TRUE;
}
SetLastErrorByStatus(Status);
SetLastErrorByStatus(Status);
}
else /* ResourceState == NULL */
else
{
SetLastError(ERROR_INVALID_PARAMETER);
SetLastError(ERROR_INVALID_PARAMETER);
}
return FALSE;