[FASTFAT]

For now, disable the VfatSetRenameInformation() asserts in trunk.
They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out.

CORE-8721 #resolve #comment Fixed with r65085

svn path=/trunk/; revision=65085
This commit is contained in:
Pierre Schweitzer 2014-10-28 20:39:42 +00:00
parent 135e926315
commit aaebdbf9d3

View file

@ -16,6 +16,8 @@
#define NDEBUG #define NDEBUG
#include <debug.h> #include <debug.h>
#define NASSERTS_RENAME
/* GLOBALS ******************************************************************/ /* GLOBALS ******************************************************************/
const char* FileInformationClassNames[] = const char* FileInformationClassNames[] =
@ -459,6 +461,11 @@ VfatSetRenameInformation(
PFILE_RENAME_INFORMATION RenameInfo, PFILE_RENAME_INFORMATION RenameInfo,
PFILE_OBJECT TargetFileObject) PFILE_OBJECT TargetFileObject)
{ {
#ifdef NASSERTS_RENAME
#pragma push_macro("ASSERT")
#undef ASSERT
#define ASSERT(x) ((VOID) 0)
#endif
NTSTATUS Status; NTSTATUS Status;
UNICODE_STRING NewName; UNICODE_STRING NewName;
UNICODE_STRING SourcePath; UNICODE_STRING SourcePath;
@ -485,6 +492,9 @@ VfatSetRenameInformation(
} }
OldReferences = FCB->parentFcb->RefCount; OldReferences = FCB->parentFcb->RefCount;
#ifdef NASSERTS_RENAME
UNREFERENCED_PARAMETER(OldReferences);
#endif
/* If we are performing relative opening for rename, get FO for getting FCB and path name */ /* If we are performing relative opening for rename, get FO for getting FCB and path name */
if (RenameInfo->RootDirectory != NULL) if (RenameInfo->RootDirectory != NULL)
@ -790,6 +800,9 @@ VfatSetRenameInformation(
/* Try to find target */ /* Try to find target */
ParentFCB = NULL; ParentFCB = NULL;
OldParent = FCB->parentFcb; OldParent = FCB->parentFcb;
#ifdef NASSERTS_RENAME
UNREFERENCED_PARAMETER(OldParent);
#endif
Status = vfatPrepareTargetForRename(DeviceExt, Status = vfatPrepareTargetForRename(DeviceExt,
&ParentFCB, &ParentFCB,
&NewName, &NewName,
@ -803,6 +816,9 @@ VfatSetRenameInformation(
} }
NewReferences = ParentFCB->RefCount; NewReferences = ParentFCB->RefCount;
#ifdef NASSERTS_RENAME
UNREFERENCED_PARAMETER(NewReferences);
#endif
FsRtlNotifyFullReportChange(DeviceExt->NotifySync, FsRtlNotifyFullReportChange(DeviceExt->NotifySync,
&(DeviceExt->NotifyList), &(DeviceExt->NotifyList),
@ -854,6 +870,9 @@ Cleanup:
if (RenameInfo->RootDirectory != NULL) ObDereferenceObject(RootFileObject); if (RenameInfo->RootDirectory != NULL) ObDereferenceObject(RootFileObject);
return Status; return Status;
#ifdef NASSERTS_RENAME
#pragma pop_macro("ASSERT")
#endif
} }
/* /*