Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-01-06 06:20:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SAMSRV]

Browse source 
SamrGetAliasMembership: Do not overwrite enties of the RID array.

svn path=/trunk/; revision=61536
This commit is contained in:
Eric Kohl 2014-01-05 12:00:16 +00:00
parent d3efc2ffdd
commit aa4d139a0c
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
reactos/dll/win32/samsrv/samrpc.c
View file

@ -3250,6 +3250,7 @@ SamrGetAliasMembership(IN SAMPR_HANDLE DomainHandle,
ULONG ValueCount; ULONG ValueCount;
ULONG DataLength; ULONG DataLength;
ULONG i, j; ULONG i, j;
ULONG RidIndex;
NTSTATUS Status; NTSTATUS Status;
WCHAR NameBuffer[9]; WCHAR NameBuffer[9];
@ -3334,6 +3335,7 @@ TRACE("Open %S\n", MemberSidString);
goto done; goto done;
} }
RidIndex = 0;
for (i = 0; i < SidArray->Count; i++) for (i = 0; i < SidArray->Count; i++)
{ {
ConvertSidToStringSid(SidArray->Sids[i].SidPointer, &MemberSidString); ConvertSidToStringSid(SidArray->Sids[i].SidPointer, &MemberSidString);
@ -3365,7 +3367,9 @@ TRACE("Open %S\n", MemberSidString);
NULL); NULL);
if (NT_SUCCESS(Status)) if (NT_SUCCESS(Status))
{ {
RidArray[j] = wcstoul(NameBuffer, NULL, 16); /* FIXME: Do not return each RID more than once. */
RidArray[RidIndex] = wcstoul(NameBuffer, NULL, 16);
RidIndex++;
} }
} }
} }