Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-29 02:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:SE] Print debug output only if NDEBUG is not defined

Browse source 
This mutes a lot of debug spam that fills up the debugger when an access
check fails because a requestor doesn't have enough privileges to access
an object.
This commit is contained in:
George Bișoc 2023-03-06 20:03:44 +01:00
parent b0a03a7caa
commit a804ba3200
No known key found for this signature in database
GPG key ID: 688C4FBE25D7DEF6
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ntoskrnl/se/debug.c
View file

@ -13,6 +13,7 @@
/* PRIVATE FUNCTIONS **********************************************************/ /* PRIVATE FUNCTIONS **********************************************************/
#ifndef NDEBUG
/** /**
* @brief * @brief
* Converts an Access Control Entry (ACE) type to a string. * Converts an Access Control Entry (ACE) type to a string.
@ -204,6 +205,7 @@ SepDumpSidsOfToken(
RtlFreeUnicodeString(&SidString); RtlFreeUnicodeString(&SidString);
} }
} }
#endif
/* PUBLIC FUNCTIONS ***********************************************************/ /* PUBLIC FUNCTIONS ***********************************************************/
@ -215,9 +217,11 @@ VOID
SepDumpSdDebugInfo( SepDumpSdDebugInfo(
_In_opt_ PISECURITY_DESCRIPTOR SecurityDescriptor) _In_opt_ PISECURITY_DESCRIPTOR SecurityDescriptor)
{ {
#ifndef NDEBUG
UNICODE_STRING SidString; UNICODE_STRING SidString;
PSID OwnerSid, GroupSid; PSID OwnerSid, GroupSid;
PACL Dacl, Sacl; PACL Dacl, Sacl;
#endif
/* Don't dump anything if no SD was provided */ /* Don't dump anything if no SD was provided */
if (!SecurityDescriptor) if (!SecurityDescriptor)
@ -225,6 +229,7 @@ SepDumpSdDebugInfo(
return; return;
} }
#ifndef NDEBUG
/* Cache the necessary security buffers to dump info from */ /* Cache the necessary security buffers to dump info from */
OwnerSid = SepGetOwnerFromDescriptor(SecurityDescriptor); OwnerSid = SepGetOwnerFromDescriptor(SecurityDescriptor);
GroupSid = SepGetGroupFromDescriptor(SecurityDescriptor); GroupSid = SepGetGroupFromDescriptor(SecurityDescriptor);
@ -264,6 +269,7 @@ SepDumpSdDebugInfo(
{ {
SepDumpAclInfo(Dacl, FALSE); SepDumpAclInfo(Dacl, FALSE);
} }
#endif
} }
/** /**
@ -274,7 +280,9 @@ VOID
SepDumpTokenDebugInfo( SepDumpTokenDebugInfo(
_In_opt_ PTOKEN Token) _In_opt_ PTOKEN Token)
{ {
#ifndef NDEBUG
UNICODE_STRING SidString; UNICODE_STRING SidString;
#endif
/* Don't dump anything if no token was provided */ /* Don't dump anything if no token was provided */
if (!Token) if (!Token)
@ -282,6 +290,7 @@ SepDumpTokenDebugInfo(
return; return;
} }
#ifndef NDEBUG
/* Dump relevant token info */ /* Dump relevant token info */
DbgPrint("================== ACCESS TOKEN DUMP INFO ==================\n"); DbgPrint("================== ACCESS TOKEN DUMP INFO ==================\n");
DbgPrint("Token -> 0x%p\n", Token); DbgPrint("Token -> 0x%p\n", Token);
@ -305,6 +314,7 @@ SepDumpTokenDebugInfo(
DbgPrint("Token restricted SIDs:\n"); DbgPrint("Token restricted SIDs:\n");
SepDumpSidsOfToken(Token->RestrictedSids, Token->RestrictedSidCount); SepDumpSidsOfToken(Token->RestrictedSids, Token->RestrictedSidCount);
} }
#endif
} }
/** /**
@ -321,10 +331,12 @@ SepDumpAccessRightsStats(
return; return;
} }
#ifndef NDEBUG
DbgPrint("================== ACCESS CHECK RIGHTS STATISTICS ==================\n"); DbgPrint("================== ACCESS CHECK RIGHTS STATISTICS ==================\n");
DbgPrint("Remaining access rights -> 0x%08lx\n", AccessRights->RemainingAccessRights); DbgPrint("Remaining access rights -> 0x%08lx\n", AccessRights->RemainingAccessRights);
DbgPrint("Granted access rights -> 0x%08lx\n", AccessRights->GrantedAccessRights); DbgPrint("Granted access rights -> 0x%08lx\n", AccessRights->GrantedAccessRights);
DbgPrint("Denied access rights -> 0x%08lx\n", AccessRights->DeniedAccessRights); DbgPrint("Denied access rights -> 0x%08lx\n", AccessRights->DeniedAccessRights);
#endif
} }
/* EOF */ /* EOF */